From 43785609c013ff3c3f7fc92740246eb3ed5423d3 Mon Sep 17 00:00:00 2001 From: Dandaedre Date: Thu, 12 Nov 2026 07:50:52 +0100 Subject: [PATCH] Swap MPC-HC previous and next transport presets --- companion-modules/media-player-classic/README.md | 5 +++++ companion-modules/media-player-classic/src/definitions.js | 5 +++-- companion-modules/media-player-classic/test/state.test.js | 4 ++-- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/companion-modules/media-player-classic/README.md b/companion-modules/media-player-classic/README.md index 71dee69..7d91198 100644 --- a/companion-modules/media-player-classic/README.md +++ b/companion-modules/media-player-classic/README.md @@ -57,6 +57,11 @@ spare page. These presets already include their feedback and variable references | Elapsed | Live elapsed media time and progress bar | | Playback state | Playing, paused, stopped, idle, or offline with matching colors | +The Previous/Next transport presets swap command IDs (Previous → `919`, Next → +`918`) to compensate for reversed navigation observed on this player. Original +numeric actions remain unchanged. Re-add copied presets to existing buttons +to apply this correction; linked presets follow the module update. + The progress bar fills from left to right. It turns amber with 10 seconds left and red with 5 seconds left. Timing displays are passive: pressing them does not send a player command. Transport presets use symbols, colors, and labels; diff --git a/companion-modules/media-player-classic/src/definitions.js b/companion-modules/media-player-classic/src/definitions.js index 6ef1e61..624be80 100644 --- a/companion-modules/media-player-classic/src/definitions.js +++ b/companion-modules/media-player-classic/src/definitions.js @@ -51,8 +51,9 @@ export function presets(label = 'MPC_DEV') { active('paused', colors.amber, 'Ⅱ\nPAUSED'), ]), transport_stop: button('Stop — red while stopped', '■\nSTOP', '890', [active('stopped', colors.red)]), - transport_previous: button('Previous playlist item', '◀◀\nPREV', '918'), - transport_next: button('Next playlist item', '▶▶\nNEXT', '919'), + // This player's playlist navigation is reversed; keep legacy numeric actions unchanged. + transport_previous: button('Previous playlist item', '◀◀\nPREV', '919'), + transport_next: button('Next playlist item', '▶▶\nNEXT', '918'), transport_mute: button('Toggle mute — red while muted', 'MUTE', '909', [active('muted', colors.red, 'MUTED')]), transport_pause: button('Pause — amber while paused', 'Ⅱ\nPAUSE', '888', [active('paused', colors.amber)]), transport_remaining: button('Remaining time and progress', `LEFT\n$(${label}:remaining)`, null, [ diff --git a/companion-modules/media-player-classic/test/state.test.js b/companion-modules/media-player-classic/test/state.test.js index 8c874c0..0a689b8 100644 --- a/companion-modules/media-player-classic/test/state.test.js +++ b/companion-modules/media-player-classic/test/state.test.js @@ -55,8 +55,8 @@ test('transport presets use playlist commands and state feedback; time displays for (const [preset, command] of [ ['play', '887'], ['stop', '890'], - ['previous', '918'], - ['next', '919'], + ['previous', '919'], + ['next', '918'], ['mute', '909'], ]) { assert.equal(buttons[`transport_${preset}`].steps[0].down[0].actionId, command)