Fix duplicate diagnostic disclosure widget IDs

This commit is contained in:
Dandaedre 2026-11-04 16:32:16 +01:00
parent fcb81e2e7c
commit 8d2b2eefd0
1 changed files with 35 additions and 0 deletions

View File

@ -1437,6 +1437,7 @@ impl App {
}
});
egui::CollapsingHeader::new(RichText::new("Technical details").weak())
.id_salt(("column_details", &table.name, code, message))
.show(ui, |ui| {
ui.add(
egui::Label::new(RichText::new(&error.message).weak())
@ -1460,6 +1461,7 @@ impl App {
);
if occurrences.len() > 1 {
egui::CollapsingHeader::new(RichText::new("Affected cells").weak())
.id_salt(("column_affected_cells", &table.name, code, message))
.show(ui, |ui| {
ui.weak(
occurrences
@ -2839,6 +2841,39 @@ mod tests {
}));
}
#[test]
fn repeated_diagnostic_groups_expand_independently_without_id_clashes() {
let mut app = sample();
app.review_view = ReviewView::Columns;
for (row, value) in [
(1, "invalid alpha"),
(2, "invalid alpha"),
(3, "invalid beta"),
(4, "invalid beta"),
] {
app.tables[0].rows[row][1].text = value.into();
}
let ctx = egui::Context::default();
configure_style(&ctx);
ctx.style_mut(|style| style.animation_time = 0.0);
let size = [1200.0, 1000.0];
render(&mut app, &ctx, size, vec![]);
let labels = render(&mut app, &ctx, size, vec![]);
let headers: Vec<_> = labels
.iter()
.filter(|(text, _)| text == "Affected cells")
.collect();
assert_eq!(headers.len(), 2);
let second = headers[1].1.center();
click_size(&mut app, &ctx, second, size);
let labels = render(&mut app, &ctx, size, vec![]);
assert!(labels.iter().any(|(text, _)| text == "Show!B4, Show!B5"));
assert!(!labels.iter().any(|(text, _)| text == "Show!B2, Show!B3"));
assert!(!labels.iter().any(|(text, _)| {
text.contains("use of widget ID") || text.contains("Widget is above this text")
}));
}
#[test]
fn bulk_ignore_includes_missing_titles_but_skips_timing_errors_and_decisions() {
let mut app = sample();