From a7a7cec04103030cee3dcbccdd048a8399e57895 Mon Sep 17 00:00:00 2001 From: Dandaedre Date: Mon, 16 Nov 2026 08:04:42 +0100 Subject: [PATCH] Focus Midra aspect work on explicit layer modes --- docs/canvas-pilot/changelog.md | 5 + .../midra-aspect-test-checklist.md | 216 +++++++----------- docs/canvas-pilot/plan.md | 28 +-- 3 files changed, 104 insertions(+), 145 deletions(-) diff --git a/docs/canvas-pilot/changelog.md b/docs/canvas-pilot/changelog.md index f665d89..767e87f 100644 --- a/docs/canvas-pilot/changelog.md +++ b/docs/canvas-pilot/changelog.md @@ -4,6 +4,11 @@ ## Unreleased +- Narrow Midra aspect work to explicit layer Crop-menu modes following operator + findings: 1:1 keeps pixel scale during resizing, and explicit layer modes + override input fill. Retire input-inheritance/correction tests from this task; + keep advanced input controls separate. Runtime behavior is unchanged. + - Add an ordered feature demonstration checklist covering project creation, editing, geometry exchange, device transfers and input previews. diff --git a/docs/canvas-pilot/midra-aspect-test-checklist.md b/docs/canvas-pilot/midra-aspect-test-checklist.md index a66ff07..511df31 100644 --- a/docs/canvas-pilot/midra-aspect-test-checklist.md +++ b/docs/canvas-pilot/midra-aspect-test-checklist.md @@ -1,179 +1,133 @@ -# Midra fill and aspect mode test checklist +# Midra layer aspect test checklist -Purpose: determine the scaling formulas, setting precedence, crop order and -clipping behavior for input **Layer fill** and layer **Aspect** modes. +Purpose: determine visible geometry, crop order, clipping and rounding for the +explicit **Aspect** modes in the Midra layer's Crop menu. Input settings remain +separate advanced controls; their inheritance is outside this implementation. -Start with sections A and B and share the results before proceeding. They may -let us shorten sections C and D. Untested cases should stay unchecked. +## Confirmed operator findings — 2026-11-16 + +- [x] **1:1 preserves pixel-for-pixel image scale regardless of layer resizing.** +- [x] Explicit layer aspect takes precedence over the input's Layer fill option. +- [x] Input Layer fill is used when layer Aspect is set to **Input setting**. + +These findings were supplied by the user. They establish scale and precedence, +not yet the exact placement/clipping behavior of 1:1 or crop processing order. + +## Implementation scope + +Support explicit **1:1, Centered, Fullscreen and Cropped** layer modes. Do not +implement input/global inheritance as part of this task. Do not change shared +input settings automatically to achieve a layer layout. Existing advanced input +controls remain separate. When loading an inherited mode, report the limitation +or require an explicit mode choice rather than guessing the effective mode. + +The checks below replace the earlier input/layer precedence matrix. Keep the +original A/C/E test identifiers where possible for any results already recorded. ## Reference setup -- [ ] Record the Midra model and firmware. -- [ ] Save the current device configuration. -- [ ] Use a **1920 × 1080 source** with a visible outer border, center crosshair, - circle and numbered grid. This makes stretching and missing edges obvious. -- [ ] Use a **1920 × 1080 output**. -- [ ] Set one live layer to **800 × 600**, centered at **(960, 540)**. - Its top-left should be **(560, 240)**. -- [ ] Disable masks, borders, shadows and other effects. -- [ ] Set input crop and layer crop to zero. -- [ ] Set input **Content ratio = Native**, **Transform to = Signal Aspect Ratio**, - and **Layer fill = Follow layer settings**. -- [ ] Change settings directly in WebRCS. **Do not send from Canvas Pilot during - these tests:** its current geometry sends force Centered. +- [ ] Record model and firmware; save the current device configuration. +- [ ] Use a **1920 × 1080 source** with an outer border, center crosshair, circle + and numbered grid, on a **1920 × 1080 output**. +- [ ] Set a live layer to **800 × 600**, centered at **(960, 540)**; + top-left **(560, 240)**. +- [ ] Disable masks, borders, shadows and other effects; reset layer crop. +- [ ] For this controlled experiment only, use an uncorrected source: input + crop zero, Content ratio Native, Transform to Signal Aspect Ratio. This is a + test baseline, not a requirement to change input settings in production. +- [ ] Set an explicit layer Aspect for every case; do not use Input setting or + Global settings. +- [ ] Work directly in WebRCS. **Do not send from Canvas Pilot during these + tests:** its current geometry sends force Centered. -Judge rendering using physical output or its multiviewer image. WebRCS alone -may show only the container. If measuring from a scaled multiviewer screenshot, -record its scale or include the full output frame so coordinates can be derived. -Keep output clipping distinct from clipping at the layer boundary. - -Copy this record for each test. Keep screenshots named after the test ID. -If a measurement is unavailable, record what is visible rather than guessing. +Judge rendering from physical output or its multiviewer image. Include the full +output frame if using a scaled screenshot. Distinguish output-edge clipping +from layer-boundary clipping. Leave unavailable measurements blank. ```text Test ID: Model / firmware: -Source signal dimensions: -Input Content ratio / Transform to / Layer fill: -Input crop (left, right, top, bottom; units): +Actual source signal dimensions: Layer Aspect: Layer center and size: Layer crop (left, right, top, bottom; units): Preview or Program: Visible image bounds (left, top, right, bottom; output pixels): Missing source edges / surviving grid lines: +Source center position on output: Circle round or stretched: Reported content dimensions, if displayed: Screenshot filename: Other observations / settings automatically changed: ``` -## A. Basic scaling modes +## A. Scaling, placement and clipping -Keep the reference setup unchanged except for **layer Aspect**. +Keep the reference setup unchanged except for layer Aspect. -| Done | Test | Layer Aspect | -| --- | --- | --- | -| [ ] | A1 | Centered | -| [ ] | A2 | Fullscreen | -| [ ] | A3 | Cropped | -| [ ] | A4 | 1:1 | - -For each, record visible bounds, whether the entire source border survives, -whether the circle stays round, and whether content extends outside the layer. - -- [ ] **A5:** Repeat 1:1 with an actual **640 × 360 source**, retaining the - 800 × 600 layer. Record image placement. Change the actual signal resolution, - not just the image drawn within a 1920 × 1080 signal. -- [ ] **A6a:** Restore the 1920 × 1080 source. Use a **600 × 800 layer**, still +- [ ] **A1:** Centered. +- [ ] **A2:** Fullscreen. +- [ ] **A3:** Cropped. +- [ ] **A4:** 1:1. Scale is already confirmed; record which source pixels are + visible, placement of the center crosshair, and clipping at the layer boundary. +- [ ] **A4b:** In 1:1, resize the layer from 800 × 600 to 1000 × 700 while keeping + its center fixed. Record which image edges move and which grid pixels survive. +- [ ] **A5:** Use an actual **640 × 360 source** in the 800 × 600 layer with 1:1. + Record where the smaller image sits and what surrounds it. Change the signal + resolution, not just the artwork within a 1920 × 1080 signal. +- [ ] **A6a:** Restore the 1920 × 1080 source; use a **600 × 800 layer**, still centered at (960, 540), with Centered aspect. - [ ] **A6b:** Repeat A6a with Cropped aspect. -## B. Input/layer precedence and inheritance +For each case, note visible bounds, surviving source borders, circle proportions +and whether content extends beyond the layer. Share A before proceeding if the +results make later cases unnecessary. -Restore the 800 × 600 layer and zero crop. Keep Content ratio = Native and -Transform to = Signal Aspect Ratio. +## C. Layer crop order -| Done | Test | Input Layer fill | Layer Aspect | -| --- | --- | --- | --- | -| [ ] | B1 | Centered | Input setting | -| [ ] | B2 | Fullscreen | Input setting | -| [ ] | B3 | Cropped | Input setting | -| [ ] | B4 | 1:1 | Input setting | -| [ ] | B5 | Fullscreen | Centered | -| [ ] | B6 | Centered | Fullscreen | -| [ ] | B7 | Follow layer settings | Input setting | +Restore the reference source and 800 × 600 layer. Keep input corrections at the +baseline above. Reset layer crop before each case, then apply only these values. -- [ ] Compare B1–B4 with A1–A4. -- [ ] Record which setting wins in B5 and B6. -- [ ] Record B7's result, including any automatic setting change or refusal. -- [ ] **B8:** Layer Aspect = Global settings; input fill = Follow layer settings. - Change the global mode between Centered and Fullscreen. Record both results - and where the global setting is located. -- [ ] **B9:** Repeat B8 with input fill = Cropped. -- [ ] **B10:** Repeat B7 while changing the global mode between Centered and - Fullscreen. This tests whether global mode resolves the inheritance loop. - -**Share A and B before continuing.** - -## C. Crop order - -Restore the 1920 × 1080 source, Native / Signal Aspect Ratio, input fill = Follow -layer settings, and the 800 × 600 layer centered at (960, 540). Reset input and -layer crop before each case, then apply only the values listed. - -| Group | Input crop | Layer crop | +| Group | Layer crop | Question | | --- | --- | --- | -| C1 | Zero | Left 25%; other edges zero | -| C2 | Left 480 source pixels; other edges zero | Zero | -| C3 | Left 480 source pixels; other edges zero | Top 25%; other edges zero | - -Run each group in all four layer modes: +| C1 | Left 25%; other edges zero | Does the remaining image rescale/recenter, and how does that depend on Aspect? | +| C4 | Left 25%, top 10%; other edges zero | How does asymmetric two-axis crop affect scale, placement and clipping? | - [ ] C1-Centered - [ ] C1-Fullscreen - [ ] C1-Cropped - [ ] C1-1:1 -- [ ] C2-Centered -- [ ] C2-Fullscreen -- [ ] C2-Cropped -- [ ] C2-1:1 -- [ ] C3-Centered -- [ ] C3-Fullscreen -- [ ] C3-Cropped -- [ ] C3-1:1 +- [ ] C4-Centered +- [ ] C4-Fullscreen +- [ ] C4-Cropped +- [ ] C4-1:1 -Record surviving grid lines, the source center's position, visible bounds and -reported content dimensions. Note whether retained content is recentered and -whether WebRCS changes displayed crop values or units. Capture the values after -applying them, including any rounding. +Record surviving grid lines, source-center position, visible bounds and reported +content dimensions. Capture crop values after applying them, including rounding. +For 1:1, specifically check whether cropping preserves the already-confirmed +pixel scale and whether the retained region is recentered or stays in place. -## D. Aspect-correction order - -Reset all crop. Restore the reference source/layer sizes and input fill = Follow -layer settings. Reset corrections between cases before applying this table. - -| Test | Content ratio | Transform to | -| --- | --- | --- | -| D1 | 4:3 | Signal Aspect Ratio | -| D2 | Native | 4:3 | -| D3 | 4:3 | 16:9 | - -- [ ] D1-Centered -- [ ] D1-1:1 -- [ ] D2-Centered -- [ ] D2-1:1 -- [ ] D3-Centered -- [ ] D3-1:1 -- [ ] D4-Centered: repeat D2 with 480 pixels of left input crop. -- [ ] D4-1:1: repeat D2 with 480 pixels of left input crop. - -Record reported content dimensions as well as the rendered result. These tests -help distinguish pixel-aspect interpretation from effective image dimensions. +The former B inheritance tests, C2/C3 input-crop combinations and D input-aspect +correction matrix are retired from this task. Existing results may be retained +as observations, but those tests are no longer prerequisites. ## E. Consistency and restoration -- [ ] **E1:** Repeat one distinctive cropped case in Preview and Program. Record - the case ID and confirm the settings are otherwise identical. -- [ ] **E2:** Put the same input into two layers: one with explicit Centered, - the other with Input setting. Change input fill from Centered to Fullscreen - and record which layer changes. Keep Content ratio and Transform to at defaults. -- [ ] **E3:** With default input settings and zero crop, try an **801 × 601** - layer at (960, 540) using Centered, then Cropped, to expose rounding. +- [ ] **E1:** Repeat one distinctive layer-cropped case in Preview and Program; + record its ID and keep all other settings identical. +- [ ] **E3:** With zero crop, use an **801 × 601** layer centered at (960, 540), + first Centered, then Cropped, to expose rounding. +- [ ] **E4:** Move a 1:1 layer without resizing it. Confirm how image placement + follows the container; keep it away from output edges to isolate layer clipping. - [ ] Restore the saved configuration. ## Results and conclusions -Fill this in after comparing observations; formulas remain hypotheses until -supported by the recorded output. - -- Effective mode precedence: -- Global/input inheritance fallback: -- Centered scaling and placement: -- Fullscreen scaling: -- Cropped scaling and clipping: -- 1:1 placement and clipping: -- Input correction / input crop / layer crop processing order: +- Centered scale and placement: +- Fullscreen scale: +- Cropped scale and clipping: +- 1:1 placement and clipping (pixel scale already confirmed): +- Layer-crop processing order: - Meaning of reported content dimensions: - Rounding behavior: - Remaining ambiguous cases: diff --git a/docs/canvas-pilot/plan.md b/docs/canvas-pilot/plan.md index a943109..f4fe35a 100644 --- a/docs/canvas-pilot/plan.md +++ b/docs/canvas-pilot/plan.md @@ -71,12 +71,14 @@ device readback and physical-screen acceptance. ## To-do list -- [ ] **Current priority: Midra input layer-fill and layer aspect modes.** Support - effective mode resolution and geometry conversion for 1:1, Centered, Fullscreen - and Cropped, including input/global inheritance. Existing input controls can - stage layer-fill changes, but layer sends force Centered and only Centered - framing is reconstructed on import. Establish precedence, crop/transform order, - clipping and rounding before extending import/send behavior. See the +- [ ] **Current priority: explicit Midra layer aspect modes.** Support geometry + conversion for 1:1, Centered, Fullscreen and Cropped in the layer Crop menu. + The user confirmed that explicit layer modes override input fill, and 1:1 + keeps pixel scale regardless of layer resizing. Input/global inheritance is + outside this task; advanced shared-input controls remain separate. Existing + sends force Centered and only Centered framing is reconstructed on import. + Establish layer-crop order, placement, clipping and rounding before extending + import/send behavior. See the [official Midra 4K V3.2 manual, pp. 66 and 87](https://dwn01.analogway.com/Site+Internet/Series/Midra+4k/Common/User+Manual/AW_Midra4K_UserManual_20260521.pdf). The manual describes controls and scope, not complete conversion equations. - [ ] **Masked Midra layer import.** Separate from aspect/fill support; verify @@ -125,14 +127,12 @@ integration planned for this scope. ### Remaining tests -- [ ] **Midra fill/aspect acceptance.** Follow the - [operator test checklist](midra-aspect-test-checklist.md). Cross input fill modes with explicit, - input-inherited and global layer modes; include conflicting settings and both - inheritance defaults. Use mismatched source/container ratios, smaller/larger - 1:1 sources, asymmetric input/layer crop, content-ratio correction and Transform - to. Record firmware, raw fields, content dimensions and visible edges on output; - compare Preview/Program and two layers sharing one input. Readback alone cannot - prove the image scaling or clipping result. +- [ ] **Midra layer aspect acceptance.** Follow the narrowed + [operator test checklist](midra-aspect-test-checklist.md): explicit modes, + mismatched source/container ratios, smaller/larger 1:1 sources, asymmetric + layer crop, placement/clipping and rounding. Compare Preview/Program and + record reported content dimensions alongside visible output. Input inheritance + and input-correction combinations are no longer test prerequisites. - [ ] **Inkscape clipboard acceptance.** Obtain a sample and validate actual copy/paste before claiming support.