From ac1787fb45a9fd8b432f3d092cc344aa4d5ef096 Mon Sep 17 00:00:00 2001 From: Dandaedre Date: Thu, 5 Nov 2026 07:06:34 +0100 Subject: [PATCH] Keep rundown GUI scrollbars visible --- crates/rundown-converter/src/gui.rs | 9 ++++++--- crates/rundown-converter/src/gui/review.rs | 15 +++++++++++---- docs/rundown-converter.md | 1 + 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/crates/rundown-converter/src/gui.rs b/crates/rundown-converter/src/gui.rs index d0fcf7a..5b3ecc5 100644 --- a/crates/rundown-converter/src/gui.rs +++ b/crates/rundown-converter/src/gui.rs @@ -1043,9 +1043,11 @@ impl App { if self.tab == Tab::Review { ui.add_enabled_ui(!busy, |ui| self.review(ui)); } else { - egui::ScrollArea::both().show(ui, |ui| { - ui.add_enabled_ui(!busy, |ui| self.pane(ui)); - }); + egui::ScrollArea::both() + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible) + .show(ui, |ui| { + ui.add_enabled_ui(!busy, |ui| self.pane(ui)); + }); } }); if busy { @@ -1078,6 +1080,7 @@ fn configure_style(ctx: &egui::Context) { ctx.set_fonts(gui_fonts()); ctx.set_visuals(egui::Visuals::dark()); let mut style = (*ctx.style()).clone(); + style.spacing.scroll = egui::style::ScrollStyle::solid(); style.spacing.item_spacing = egui::vec2(10.0, 10.0); style.visuals.override_text_color = Some(Color32::from_rgb(218, 224, 235)); for role in [egui::TextStyle::Body, egui::TextStyle::Button] { diff --git a/crates/rundown-converter/src/gui/review.rs b/crates/rundown-converter/src/gui/review.rs index ab76e7a..447b15e 100644 --- a/crates/rundown-converter/src/gui/review.rs +++ b/crates/rundown-converter/src/gui/review.rs @@ -801,6 +801,7 @@ impl App { ReviewView::Rows => self.schedule_preview(ui), ReviewView::Columns => { egui::ScrollArea::vertical() + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible) .id_salt("columns_scroll") .auto_shrink([false, false]) .show(ui, |ui| self.columns_view(ui)); @@ -812,6 +813,7 @@ impl App { .default_width(560.0) .resizable(true) .vscroll(true) + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible) .show(ui.ctx(), |ui| { ui.add_enabled_ui(self.rx.is_none(), |ui| self.resolution_controls(ui)); }); @@ -895,7 +897,8 @@ impl App { if compact { "Choose a row type below, or enter an event duration." } else { "This row has no timing. Choose Note, Marker or Gap below, or supply a duration if it is an event." } } else { explanation }; - egui::ScrollArea::vertical().id_salt("issue_explanation").max_height(48.0).show(ui, |ui| { ui.label(explanation); }); + egui::ScrollArea::vertical() + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible).id_salt("issue_explanation").max_height(48.0).show(ui, |ui| { ui.label(explanation); }); }); ui.add_space(4.0); } @@ -1059,6 +1062,7 @@ impl App { .default_width(620.0) .default_height(560.0) .vscroll(true) + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible) .show(ctx, |ui| { if let Some(preview) = &preview { ui.heading(&preview.title); @@ -1251,6 +1255,7 @@ impl App { .default_width(480.0) .resizable(true) .vscroll(true) + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible) .show(ctx, |ui| { ui.heading(&preview.title); ui.label("Inferred schedule interval ยท no source row or timer"); @@ -1816,11 +1821,12 @@ impl App { _ => "No rows match this filter. Choose All rows to review exclusions.", }); } - let compact = ui.available_width() < 760.0; + let table_width = ui.available_width() - ui.spacing().scroll.allocated_width(); + let compact = table_width < 760.0; let title_width = if compact { - (ui.available_width() - 300.0).max(180.0) + (table_width - 300.0).max(180.0) } else { - (ui.available_width() - 370.0).max(240.0) + (table_width - 370.0).max(240.0) }; let jump = self.jump_row; let mut jump_visible = !rows.iter().any(|r| Some(r.row) == jump); @@ -1867,6 +1873,7 @@ impl App { })) .collect(); let mut scroll = egui::ScrollArea::both() + .scroll_bar_visibility(egui::scroll_area::ScrollBarVisibility::AlwaysVisible) .id_salt("merged_schedule") .auto_shrink([false, false]); if let Some(offset) = self.review_scroll.take() { diff --git a/docs/rundown-converter.md b/docs/rundown-converter.md index ffa3e50..464e2db 100644 --- a/docs/rundown-converter.md +++ b/docs/rundown-converter.md @@ -110,6 +110,7 @@ visually distinct from labels and ordinary actions; the active tab uses the stro formulas). Pending edits are distinguished from the last analyzed timing. **Issues** opens the issue navigator, including sheet-level and gap errors. The table fills the remaining space; its title column expands with the window. + Scrollable panels and dialogs use always-visible, solid scrollbars. Preview cells align at the top; blank title lines are omitted without changing original values in the inspector or exports. On narrow windows, timing values stack so corrections remain accessible. Changes require recheck;