Stretch review table with window and hide selection outline

This commit is contained in:
Dandaedre 2026-11-03 15:02:52 +01:00
parent 22f6ec367d
commit c20b50b507
2 changed files with 27 additions and 8 deletions

View File

@ -730,9 +730,9 @@ impl App {
}
let compact = ui.available_width() < 760.0;
let title_width = if compact {
(ui.available_width() - 300.0).clamp(180.0, 320.0)
(ui.available_width() - 300.0).max(180.0)
} else {
(ui.available_width() - 370.0).clamp(240.0, 450.0)
(ui.available_width() - 370.0).max(240.0)
};
let jump = self.jump_row;
let mut jump_visible = !rows.iter().any(|r| Some(r.row) == jump);
@ -968,10 +968,6 @@ impl App {
details = Some(row.row);
}
}
if row.row > 0 && self.selected_row == Some(row.row) {
ui.painter().rect_stroke(row_rect, 2.0,
egui::Stroke::new(1.0_f32, ui.visuals().selection.bg_fill), egui::StrokeKind::Inside);
}
}
});
@ -1270,6 +1266,28 @@ mod tests {
assert_eq!(app.selected_row, Some(2));
}
#[test]
fn table_expands_and_shrinks_with_the_window() {
let mut app = sample();
let ctx = egui::Context::default();
configure_style(&ctx);
let mut positions = Vec::new();
for width in [860.0, 1260.0, 860.0] {
for _ in 0..3 {
render(&mut app, &ctx, [width, 620.0], vec![]);
}
let labels = render(&mut app, &ctx, [width, 620.0], vec![]);
let controls = labels.iter().find(|(s, _)| s == "Auto (Event)").unwrap().1;
positions.push(controls.left());
assert!(
width - controls.right() < 150.0,
"Controls should follow the right edge"
);
}
assert!((positions[1] - positions[0] - 400.0).abs() < 2.0);
assert!((positions[2] - positions[0]).abs() < 2.0);
}
#[test]
fn titles_align_with_or_without_issue_buttons() {
for size in [[860.0, 620.0], [560.0, 400.0]] {

View File

@ -37,7 +37,7 @@ click **Analyze rundown**. Review has two views:
- **Schedule & corrections** combines the schedule preview and row editing in one
table. Start/end/duration, titles, colored issues and row types are visible
together. Click anywhere on a source row to select it; its outline shows selection.
together. Click anywhere on a source row to target it for editing.
**Edit row…** opens the selected row editor, including duration correction. **All rows** includes ignored rows;
**Included rows** hides ignored rows and rows containing only ignored columns,
while keeping notes, markers and breaks; **Needs attention** shows rows with
@ -63,7 +63,8 @@ click **Analyze rundown**. Review has two views:
decisions and a formatted table of original cells (including empty values and
formulas). Pending edits are distinguished from the last analyzed timing.
**Issues** opens the issue navigator, including sheet-level and gap errors.
The table fills the remaining space. On narrow windows,
The table fills the remaining space; its title column expands with the window.
On narrow windows,
timing values stack so corrections remain accessible. Changes require recheck;
the timing preview and diagnostics continue to show the previous analysis.
- **Columns** shows inference evidence, per-column role dropdowns, and sample