docs: record completed M13 implementation and automated qualification
Rust CI fader_master passed its selected CI mode.
MadGobblins/fader_master/pipeline/head This commit looks good Details

Verify: cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features; cargo test --workspace --all-targets --all-features; cargo test --workspace --doc --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo build --workspace --release --all-features all passed. Default/no-default workspace and portable/individual-backend tests and builds passed. Private D-Bus fixtures: 2 passed. scripts/test-ci.sh and git diff --check passed. Real QBZ/controller and provisioned Jenkins runs remain explicitly unverified.
This commit is contained in:
Dandaedre 2026-10-18 23:08:47 +02:00
parent 31a2fa338a
commit 814c87cc6e
Signed by: Dandaedre
GPG Key ID: 440C6592E8A26D99
2 changed files with 31 additions and 17 deletions

View File

@ -141,7 +141,7 @@ enrichment; MPRIS controls are implemented on the development branch after RC2.
The existing `media.name` regex `(?i) - YouTube$` is sufficient for YouTube
streams whose reported title has that suffix. Do not couple this use case to
browser identity, window-title concatenation, or the future AND matcher.
browser identity, window-title concatenation, or the AND matcher.
AND composition must preserve the meaning of existing OR selector lists and
keep field matching explicit, validated, and visible in the editor. Process

46
task.md
View File

@ -592,21 +592,21 @@ YouTube capture use case; no browser-name condition is needed.
save/reload/restart regression. Workspace formatting, check, tests, doc tests,
clippy and release build pass, as do default/no-default and individual backend
builds. Existing profile semantics remain unchanged.
- [ ] **M13.2 Richer process metadata:** enrich stream metadata with available
- [x] **M13.2 Richer process metadata:** enrich stream metadata with available
process paths and Steam launch identity, then expose validated matcher fields
and useful diagnostics. Dependencies: M1.2, M4. Acceptance: bounded adapter
reads, PID-reuse protection, selective Steam environment keys, and explicit
unavailable state for exited/inaccessible/sandboxed processes. Tests cover
native and Proton-like fixtures, Steam IDs, non-Steam processes and path-only
hints; a `steamapps` path must not be treated as proof Steam launched a game.
First slice: bounded Pulse-worker enrichment and four selectable fields
Implemented: bounded Pulse-worker enrichment and four selectable fields
(executable, working_directory, steam.app_id, steam.game_id), local-machine
guard and start-time consistency check. Fixture coverage includes missing
process data, PID reuse, Steam/path-only cases, malformed IDs and bounded
reads. Config now includes per-stream normalized metadata diagnostics, including
explicit unavailable values; native/Proton-like, restricted-environment and
exit-during-read fixtures are covered. Real-process checks remain opt-in.
- [ ] **M13.3 Targeted MPRIS controls:** add Play, Pause and PlayPause via matched
- [x] **M13.3 Targeted MPRIS controls:** add Play, Pause and PlayPause via matched
player identity/desktop ID/bus name, without keyboard simulation.
Dependencies: M13.1, M13.2, M5.2, M9.5. Acceptance: a QBZ-specific binding
affects only its resolved player; paused players with no audio stream remain
@ -616,37 +616,51 @@ YouTube capture use case; no browser-name condition is needed.
a fake D-Bus adapter before opt-in player integration checks.
Approved implementation slices for M13.3 (each independently tested/committed):
- [ ] **M13.3a Feedback switches:** persisted global MIDI-feedback gate and
- [x] **M13.3a Feedback switches:** persisted global MIDI-feedback gate and
per-fader/per-media-entry gates; global off overrides local settings and sends
no output, including clearing messages; re-enable resynchronizes observed state.
Global and per-fader gates are implemented in configuration/runtime and TUI;
per-media-entry gate follows with the media schema.
- [ ] **M13.3b MPRIS adapter:** session-bus discovery independent of audio streams,
All three gates are implemented in configuration/runtime and TUI, applied on
Save. Tests cover no-clear suppression, observed-state resync and explicit maps.
- [x] **M13.3b MPRIS adapter:** session-bus discovery independent of audio streams,
bounded calls, capability reporting, owner-change handling and reconnects.
Verify dependency license, native prerequisites and Rust 1.88 compatibility.
Worker and native adapter implemented with pinned dbus 0.9.12; fake-adapter
tests and isolated dbus-run-session discovery/Play readback fixture pass.
Live-server wiring and final workspace qualification follow.
- [ ] **M13.3c Media entries:** stable IDs, labels, exact/regex selectors on bus
tests and two isolated dbus-run-session fixtures pass: paused discovery,
transport/extended actions, readback, capability changes, timeouts/recovery and
owner replacement. Session-bus availability survives individual player errors.
- [x] **M13.3c Media entries:** stable IDs, labels, exact/regex selectors on bus
name, desktop entry or identity; live picker plus manual entry; reject ambiguous
targets rather than selecting arbitrarily. Persist MIDI action bindings.
Hardware-free contracts and validated transactional profile entries are in
place; discovery, live editing and MIDI routing integration follow.
- [ ] **M13.3d Media tab:** server-advertised availability, A/E/D editing,
Hardware-free contracts, bounded validated profiles, live picker/manual
selectors and MIDI press-edge routing are integrated. Save/restart/unbind/delete
regression exercises IPC and active-versus-draft boundaries.
- [x] **M13.3d Media tab:** server-advertised availability, A/E/D editing,
validated Save and exit, MIDI Learn with U to unbind; retain offline entries.
Support Play, Pause, Stop, PlayPause, Next and Previous with capability checks.
- [ ] **M13.3e Playback feedback:** confirmed Playing/Paused/Stopped exclusively
- [x] **M13.3e Playback feedback:** confirmed Playing/Paused/Stopped exclusively
lights the corresponding transport buttons; default same-note 127/0, explicit
device-specific colour values; clear unavailable targets only when enabled.
Deduplicate and resync after reconnect; failed commands never imply success.
- [ ] **M13.3f Extended controls:** relative seeking with configurable steps and
- [x] **M13.3f Extended controls:** relative seeking with configurable steps and
absolute position where supported; shuffle toggle/set; repeat Off/Track/Playlist
set/cycle; discover/select/activate playlists with MIDI bindings and confirmed
feedback where reported. Playlist-content editing is outside this scope.
- [ ] **M13.3g Qualification:** document schema/UI, save/reload/restart tests,
- [x] **M13.3g Qualification:** document schema/UI, save/reload/restart tests,
fake-bus failures and capability changes, workspace gates, opt-in QBZ/controller
integration checks. No keyboard simulation or playerctl dependency.
M13 automated qualification (2026-10-18, Rust 1.88.0): all six workspace gates
passed: fmt check, all-target/all-feature check and tests, doc tests, clippy with
warnings denied, and all-feature release build. Default/no-default workspace
tests, portable-library tests/builds and independent MIDI/Pulse/MPRIS feature
tests/builds passed. Both isolated private-bus fixtures passed; CI script tests
passed and Jenkins now includes the media crate plus the private-bus fixture.
The complete QBZ example validates and round-trips all action kinds. Documentation
and the opt-in real QBZ/controller checklist are updated. Real hardware/player
checks and a provisioned Jenkins execution are **not claimed**; their existing
release/manual qualification items remain open. M13 completion does not complete
native PipeWire, relative groups, M0.2 or the wider release backlog.
## User requirement coverage
| # | Requirement | Work items |