From ad71ef4161db337954a39d70d67bdc490925780b Mon Sep 17 00:00:00 2001 From: Dandaedre Date: Thu, 15 Oct 2026 02:32:15 +0200 Subject: [PATCH] docs(M8.1): record profile mixer acceptance Validation: git diff --cached --check --- checklist.md | 34 +++++++++++++++++----------------- task.md | 10 +++++++++- 2 files changed, 26 insertions(+), 18 deletions(-) diff --git a/checklist.md b/checklist.md index b6956e7..680e214 100644 --- a/checklist.md +++ b/checklist.md @@ -285,53 +285,53 @@ still `adopt`: discovery must not change live audio. ## Start configured playback and server -- [ ] Start Qobuz playback and, if available, audio in Firefox, Chromium, +- [x] Start Qobuz playback and, if available, audio in Firefox, Chromium, Chrome, Brave, or Librewolf. Record their current volume and mute values. -- [ ] In terminal 1 run: +- [x] In terminal 1 run: ```sh cargo run --locked -p fader_master -- serve \ --config examples/profiles/arch-pipewire.toml --audio pulse ``` -- [ ] Confirm startup does not change either application's volume or mute. -- [ ] Run `cargo run --locked -p fader_master -- status`. Confirm it reports +- [x] Confirm startup does not change either application's volume or mute. +- [x] Run `cargo run --locked -p fader_master -- status`. Confirm it reports exactly three configured objects: `Music`, `Browser`, and `Media group`. A stopped application must say `offline`; it must not vanish. -- [ ] Confirm `Music` is online while Qobuz plays. If a playing browser remains +- [x] Confirm `Music` is online while Qobuz plays. If a playing browser remains offline, paste its earlier raw-stream metadata so its selector can be added. ## Exercise applications and the group -- [ ] In terminal 2 run `cargo run --locked -p fader_master -- tui` and confirm +- [x] In terminal 2 run `cargo run --locked -p fader_master -- tui` and confirm the three rows are labeled as two applications and one group. -- [ ] Select `Music`, press `←` or `→` once, and confirm Qobuz changes while the +- [x] Select `Music`, press `←` or `→` once, and confirm Qobuz changes while the browser does not. -- [ ] Select `Browser`, press `m` twice, and confirm only browser audio mutes and +- [x] Select `Browser`, press `m` twice, and confirm only browser audio mutes and unmutes. Skip this item if no browser stream is matched. -- [ ] With both applications online, set their volumes to visibly different +- [x] With both applications online, set their volumes to visibly different values in the desktop mixer. Confirm `Media group` displays `MIXED` and its meter represents the louder member. -- [ ] Select `Media group` and press `←` or `→` once. Confirm both applications +- [x] Select `Media group` and press `←` or `→` once. Confirm both applications converge to the same displayed volume because this profile uses `volume_mode = "absolute"`. -- [ ] Give the two applications different mute states externally. Confirm the +- [x] Give the two applications different mute states externally. Confirm the group displays `MIXED`; press `m` once to mute every member and again to unmute every member without changing their gains. -- [ ] Stop Qobuz playback. Confirm `Music` remains visible as `OFFLINE`, the +- [x] Stop Qobuz playback. Confirm `Music` remains visible as `OFFLINE`, the group immediately reflects only its remaining browser member, and volume/mute keys on the offline row show an error without affecting other audio. -- [ ] Restart Qobuz and confirm the existing `Music` row becomes live again. +- [x] Restart Qobuz and confirm the existing `Music` row becomes live again. ## Layout, lifecycle, and report -- [ ] Resize the terminal both narrower/shorter and wider/taller. Confirm no +- [x] Resize the terminal both narrower/shorter and wider/taller. Confirm no panic or corrupt terminal, and that moving selection keeps the selected row visible. -- [ ] Quit and reopen the TUI while the server remains running. Confirm the +- [x] Quit and reopen the TUI while the server remains running. Confirm the current group/application state is resynchronized on attach. -- [ ] Restore the original application volumes and mute states, then stop the +- [x] Restore the original application volumes and mute states, then stop the server with `Ctrl-C`. -- [ ] Report any unmatched application, wrong group member, unexpected startup +- [x] Report any unmatched application, wrong group member, unexpected startup write, missing `MIXED`/`OFFLINE` indication, non-converging write, or layout problem. diff --git a/task.md b/task.md index f7dd0a6..cd94c5e 100644 --- a/task.md +++ b/task.md @@ -220,7 +220,9 @@ Dependencies: M7, M4 for real use. and fans group writes out with absolute/relative policy. It refreshes without blocking server operation and shows pending, read-only, and error indicators. Keep this item open until pickup state is integrated and the profile-aware - hands-on checks, including terminal resize, pass. + hands-on checks, including terminal resize, pass. The profile-aware hands-on + slice passed on 2026-10-15; pickup remains. A later UI refinement should add + a denser row mode and/or horizontal fader layout for smaller terminals. - [ ] **M8.2 Devices/status:** show adapter selection/probe errors, device mappings, ambiguity and persistence problems. Tests: disconnected/unsupported states have useful actions; manual backend selection validates rather than silently applying incompatible mappings. - [ ] **M8.3 Terminal lifecycle:** restoration on normal/error exit, nonblocking refresh, logging away from display. Tests: injected IO/client failure releases terminal guard; polling/refresh does not block server operation. @@ -248,6 +250,12 @@ workspace formatting, all-target/all-feature checks and tests, doctests, strict Clippy, release build, default and no-default-feature tests, and isolated Pulse, no-audio, midir, and no-MIDI feature checks pass on Rust 1.88.0. +The subsequent hands-on run passed application-isolated writes, two-member +absolute group writes, mixed gain/mute aggregation, offline/rejoin behavior, +resize, and reconnect. Waterfox initially remained offline because its reported +`Waterfox`/`waterfox-bin` metadata was absent from the example selector; the +regression-tested profile fix then matched it into the two-stream media group. + ## M9 — TUI configuration editor Dependencies: M8, M2, M1.