Commit Graph

15 Commits

Author SHA1 Message Date
Dandaedre 1b32efec9f
fix: default mute feedback to the same note on all devices
M6.1: Remove APC USB identity and LED note restrictions. Note mute bindings with an output use their original channel and note with on=127/off=0. Alternate note/CC protocols and values remain explicit feedback configuration. Document the default and overrides.

Tests: generic controller regression failed before implementation; cargo test -p fader-config --test editor (23 tests) and cargo test -p fader_master --lib feedback (2 tests) pass. Formatting, workspace all-target/all-feature check, strict Clippy, doctests and release build pass. Full workspace all-target/all-feature tests with --no-fail-fast exercise all targets: same four pre-existing Arch-profile fixture failures; all remaining tests pass. No hardware LED test performed.
2026-10-18 13:50:46 +02:00
Dandaedre 7a0e8840ed
fix: supply APC Mini mute feedback for fresh profiles
M6.1: Resolve missing feedback from the original APC Mini USB identity and supported note LED map, allowing the first learned mute binding to send confirmed feedback. Preserve explicit mappings and exclude unknown/outputless devices, unsupported controls, and MK2. Resolve defaults without rewriting user profiles.

Tests: fresh-profile planner regression failed with zero messages before the fix and passes after it. Added device/control exclusion and override coverage. cargo fmt --all -- --check, cargo check --workspace --all-targets --all-features, cargo clippy --workspace --all-targets --all-features -- -D warnings, cargo test --workspace --doc --all-features, cargo build --workspace --release --all-features pass. cargo test --workspace --all-targets --all-features --no-fail-fast --quiet exercises all targets: four existing Arch-profile fixture failures (schema ID and three MIDI device/routing assertions); remaining tests pass. Physical LED verification not performed.
2026-10-18 13:47:27 +02:00
Dandaedre 5983b1cfb5
fix: materialize omitted config arrays during edits
Treat omitted default-empty binding, application, group, and fader arrays consistently with profile validation. Creation edits now materialize missing arrays, unlearning from an omitted binding array is a no-op, and malformed present sections remain startup errors.

Tests: cargo fmt --all -- --check; cargo test -p fader-config --test editor; cargo check --workspace --all-targets --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; malformed-profile refusal and legacy-profile upgrade tests; cargo test --workspace --doc --all-features; cargo build --workspace --release --all-features. Full workspace tests stop at the pre-existing edited examples/profiles/arch-pipewire.toml fixture mismatch.
2026-10-18 12:58:19 +02:00
Dandaedre 34c738847f
feat: rename targets from the fader editor
Add a Name row and cursor-aware rename modal for application and group faders. Persist only the target display label while retaining stable IDs, selectors, group membership, bindings, and layout; keep backend-owned output labels unchanged.

Tests: cargo fmt --all; cargo check --workspace --all-targets --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo test -p tui; cargo test -p fader-config --test editor; targeted fader_master editor test; cargo test --workspace --doc --all-features; cargo build --workspace --release --all-features. Full workspace tests stop at the pre-existing edited examples/profiles/arch-pipewire.toml fixture mismatch.
2026-10-18 12:49:24 +02:00
Dandaedre 1863f82f15
feat: remove MIDI devices from Config
Add confirmed MIDI surface removal in the Config tab, clear its bindings and default-controller reference atomically, and keep added or removed devices consistent in the draft view until Save.

Tests: cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo test -p tui; cargo test -p fader-config --test editor; targeted fader_master editor/live tests; cargo test --workspace --doc --all-features; cargo build --workspace --release --all-features. Full workspace tests are blocked by the pre-existing edited examples/profiles/arch-pipewire.toml fixture mismatch.
2026-10-18 12:45:36 +02:00
Dandaedre a967cc30ea
fix: infer feedback for learned mute bindings
Copy an unambiguous same-surface, same-message-kind feedback convention onto new mute bindings while preserving device-specific values and refusing conflicting guesses.\n\nTests: cargo fmt --all -- --check\nTests: cargo test -p fader-config --test editor --all-features\nTests: cargo check --workspace --all-targets --all-features\nTests: cargo clippy --workspace --all-targets --all-features -- -D warnings
2026-10-18 12:08:14 +02:00
Dandaedre 832a04cb67
feat(M9.6): add mixer object workflows
Add transactional fader and group creation, generic confirmed deletion, and the mixer add chooser. Complete the single-screen configuration workflow with tiny-terminal coverage and updated documentation.\n\nTests: cargo fmt --all -- --check\nTests: cargo check --workspace --all-targets --all-features\nTests: cargo test --workspace --all-targets --all-features\nTests: cargo test --workspace --doc --all-features\nTests: cargo clippy --workspace --all-targets --all-features -- -D warnings\nTests: cargo build --workspace --release --all-features\nTests: cargo test --workspace --all-targets --no-default-features\nTests: cargo test -p midi --no-default-features --all-targets\nTests: cargo test -p midi --no-default-features --features midir --all-targets\nTests: cargo test -p volume_lib --no-default-features --all-targets\nTests: cargo test -p volume_lib --no-default-features --features pulse --all-targets
2026-10-18 11:22:02 +02:00
Dandaedre 8add95df3f
docs: refresh all guides and regenerate mixer screenshots
Rust CI fader_master passed its selected CI mode.
MadGobblins/fader_master/pipeline/head This commit looks good Details
Bring README, architecture, backlog, checklist, steward baseline, and every docs guide up to date. Document unnamed spacers, current setup/save/restart behavior, MIDI feedback and portable builds. Replace both screenshots with current representative layouts and fixed cell-grid SVG text/border rendering.

Validation PASS: local file links across all 12 Markdown documents; both SVGs parsed and visually inspected after rsvg-convert; repeated doc_screenshots generation produced identical SHA-256 hashes; git diff --check; cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; canonical architecture-profile schema test; portable no-default-feature package check. Full workspace gates passed in preceding empty-separator implementation commit.
2026-10-16 19:38:59 +02:00
Dandaedre 2e03e8f60c
feat(M9.4): add separator sizes and independent decorations
Edit separator name, Slim/Standard/Thick/Fill size, and Plain/Line/Double/Box decoration in one popup. Persist presentation fields and distribute spare viewport space among Fill separators after fitting faders. Bump IPC to 19.

Verification PASS: cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features; cargo test --workspace --all-targets --all-features --quiet (2 opt-in hardware tests ignored); cargo test --workspace --doc --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo build --workspace --release --all-features; cargo check --workspace; cargo check --workspace --no-default-features; cargo check -p midi --no-default-features --features midir; cargo check -p volume_lib --no-default-features --features pulse. Targeted TUI suite passed after final viewport bounds adjustment. Regression coverage includes save/reload, popup cancellation, fill allocation, small displays, and saved-layout swapping.
2026-10-16 19:27:46 +02:00
Dandaedre 4e0d3e99a7
feat: configure pickup status presentation
Rust CI fader_master passed its selected CI mode.
MadGobblins/fader_master/pipeline/head This commit looks good Details
Add persisted Detailed, Compact, Symbol, Color, and Hidden pickup-status modes to the Config page and both mixer layouts.

Tests: cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features; cargo test --workspace --all-targets --all-features; cargo test --workspace --doc --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo build --workspace --release --all-features; cargo check --workspace; cargo check --workspace --no-default-features; cargo check -p midi --no-default-features --features midir; cargo check -p volume_lib --no-default-features --features pulse
2026-10-16 19:11:40 +02:00
Dandaedre c1f3377914
feat: bootstrap controllers from MIDI discovery
Adopt a sole MIDI input when creating a managed profile, publish other unclaimed inputs to Config, and let the user add them as durable surfaces. Legacy empty profiles can add a safe Master fader, then Save and use the existing MIDI Learn flow without editing TOML.

Tests: cargo test --workspace --all-targets --all-features; cargo test --workspace --doc --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo build --workspace --release --all-features; default/no-default/midir/pulse cargo checks
2026-10-16 19:05:29 +02:00
Dandaedre 51565940a9
feat: switch profiles from the TUI
Test: cargo test -p fader_master profile_switch_prepares_before_commit_and_invalid_candidate_keeps_old_profile --locked
Test: cargo test -p tui --all-targets --all-features --locked
Test: cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
Test: cargo fmt --all -- --check
2026-10-16 18:51:28 +02:00
Dandaedre a464735f54
feat: add bordered slim fader density
Add a persisted Bordered slim size between Slim and Standard. It renders as a three-row bordered vertical card and a compact horizontal strip, and round-trips through config, IPC, the editor, and TUI.

Tests: cargo test -p fader-config -p tui --all-targets --all-features --locked
Tests: cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
Tests: cargo fmt --all -- --check
2026-10-16 00:06:31 +02:00
Dandaedre a47e1452bd
feat: reflect confirmed mute state over MIDI
Rust CI fader_master passed its selected CI mode.
MadGobblins/fader_master/pipeline/head This commit looks good Details
Open and reconcile configured MIDI outputs independently, send opt-in note or CC feedback from confirmed mute observations, deduplicate successful values, and resynchronize after reconnect. Enable green mute feedback in the APC MINI example and document the profile fields and mixed/offline policy.

Tests: cargo fmt --all -- --check
Tests: cargo check --workspace --all-targets --all-features --locked
Tests: cargo test --workspace --all-targets --all-features --locked
Tests: cargo test --workspace --doc --all-features --locked
Tests: cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
Tests: cargo build --workspace --release --all-features --locked
Tests: cargo check --workspace --locked
Tests: cargo check --workspace --no-default-features --locked
Tests: cargo check -p midi --no-default-features --features midir --locked
Tests: cargo check -p volume_lib --no-default-features --features pulse --locked
2026-10-15 23:55:29 +02:00
Dandaedre 9464944634
docs: showcase the TUI and centralize guides
Rust CI fader_master passed its selected CI mode.
MadGobblins/fader_master/pipeline/head This commit looks good Details
Validation: regenerated deterministic SVG screenshots twice with identical output; xmllint --noout docs/images/*.svg; cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features; cargo test --workspace --all-targets --all-features; cargo test --workspace --doc --all-features; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo build --workspace --release --all-features; default, no-default-features, midir, and pulse checks.
2026-10-15 23:19:22 +02:00