Commit Graph

53 Commits

Author SHA1 Message Date
Jeremiah Leary 7a3fcf9883 Updates for issue #434:
Adding rules to align declaration identifiers:

  1)  Updated documentation
  2)  Removed the following rules
      file_003, constant_003, attribute_003, signal_003, subtype_003, type_003 and variable_003
  3)  Added new rules:
      architecture_029, function_015, package_019, procedure_010 and process_037
  4)  Added tests for new rules
  5)  Updated classifiers to support new rules
2020-06-30 11:36:01 -05:00
Martin Dörfelt b90d94cbcf added rules for generate and process label prefixes 2020-06-25 21:42:27 +02:00
Jeremiah Leary d2e883b96d Updates for issue #405
Attempting to recreate issue:

  1) Enhanced test for process_018.  However, it does not fail.

Will attempt to recreate issue on branch release_1.0_support.
2020-06-03 19:54:32 -05:00
Jeremiah Leary d8fd3a5385 Updates for issue #385:
Rule process_031 could not handle multiple variables defined on a single line:

  1)  Updated tests to expose issue
  2)  Updated code to fix issue
2020-05-11 21:25:41 -05:00
Jeremiah Leary de942890b3 Updates for issue #385:
The rule process_031 was attempting to align variables defined in function and procedures with variables outside functions and procedures in the process declarative region.

  1)  Updated tests to expose issue
  2)  Fixed to make tests pass

Additional issue found with handling indents on processes with just 'process is' when updating tests.

  1)  Fixed code to make tests pass
2020-05-09 09:12:19 -05:00
Jeremiah Leary cafe651a15 Updates for issue #379:
Rule process_019 was not honoring records.

  1)  Updated tests
  2)  Updated clock detection
  3)  Update rule process_019
2020-04-27 20:20:51 -05:00
Jeremiah C Leary 01746e70ea Merge branch 'master' into issue-362 2020-03-31 21:16:50 -05:00
Jeremiah C Leary b9abdf8a57 Updates for issue #362:
Updated rules to use consistent violation dictionary:

  1)  Updated check.indent_of_comments_above to use the violation dictionary
  2)  Updated rules to use the violation dictionary
  3)  Updated tests
2020-03-31 20:09:51 -05:00
Michał Kruszewski b6226ecb7d Set the default case to lowercase for all case rules. 2020-03-29 21:26:15 +02:00
Jeremiah C Leary 7d85a98db4 Updates for issue #362:
Interim commit to move all rules to new violation dictionary format.
2020-03-29 13:09:38 -05:00
Michał Kruszewski 2f08a64bda Refactor keyword alignment rules. 2020-02-24 21:14:44 +01:00
Jeremiah C Leary 7d940306ec Updates for issue #314 and issue #333:
Issue #314:

Updated all label rules to use utils.extract_label or utils.extract_end_label:

  1) Added utils.extract_end_label
  2) Added more end label attributes to line.py
  3) Updated classifiers to set the new end label attributes
  4) Updated tests
  5) Updated rules to use utils.extract_label or utils.extract_end_label

Issue #333:

Fixed bug where nested generate labels were not updated correctly:

  1)  Added test case
  2)  Updated code
2020-02-23 10:51:44 -06:00
Jeremiah C Leary b32eb8ffe6 Updates for issue #335:
Updated process rules to use a dictionary for the violations list.

  1)  Updated code
  2)  Updated tests
2020-02-16 09:51:38 -06:00
Jeremiah C Leary ddc32f8ed9 Updates for issue #335:
Updated tests using the indent base rule to use dictionaries for the violation list.

  1)  Updated code
  2)  Updated tests
2020-02-16 08:27:55 -06:00
Jeremiah C Leary f370aeadd1 Updates for issue #335
Updated rules using single_space_before_rule to use dictionaries for items in the violations list.

  1)  Updated tests
  2)  Updated code
2020-02-15 19:23:21 -06:00
Jeremiah C Leary aca83b6b03 Updates for issue #335
Updated rules using the single_space_before_character_rule to use dictionaries in the violation attribute.

  1)  Updated tests
  2)  Updated code
2020-02-15 19:13:40 -06:00
Jeremiah C Leary 2dc372a6f4 Updates for issue #335
Updated rules using is_single_space_after_character_rule to use dictionaries for entries in the violation list.

  1)  Updated tests
  2)  Updated code
2020-02-15 18:58:47 -06:00
Jeremiah C Leary fb4c5ca972 Updates for issue #335:
Updated rules based on the single_space_after_rule and multiple_spaces_after_rule base rules:

  1)  Updated rules to use violations list for the fix phase
  2)  Updated tests
2020-02-15 16:12:47 -06:00
Jeremiah C Leary 53969af391 Updates for issue #335
Updated rules based on rules.line_below_rule to use the violations attribute to fix violations.

  1)  Updated base rule rules.line_below_rule
  2)  Updated tests
2020-02-15 15:36:42 -06:00
Jeremiah C Leary 128b080f49 Updates for issue #335
Updated rules based on the line_above_rule.

  1)  Updated line_above_rule
  2)  Updated tests
2020-02-15 15:13:57 -06:00
Jeremiah C Leary 54cefdb6cf Merge branch 'master' of https://github.com/jeremiah-c-leary/vhdl-style-guide 2020-02-15 10:05:57 -06:00
Jeremiah C Leary e8f3f4ad71 Updates for issue #335
Switched self.dFix in process_018 to use dViolation.

  1) Added additional test case
  2) Updated code
  3) Updated existing test case
  4) Added function to test.utils to add the proper formatting of violations during the check.
2020-02-15 09:53:44 -06:00
Michał Kruszewski 7666fae485 Make case_rule to use violations attribute for fixing errors. 2020-02-15 16:51:01 +01:00
Jeremiah C Leary f684b4b0a7 Updates for issue #319:
Added ability to configure either 'event or _edge for clock definitions:

  1)  Updated documentation
  2)  Added isClockDefinition to line object
  3)  Updated process classification to set isClockDefinition
  4)  Updated tests
  5)  Updated rule process_029
2020-01-06 22:18:07 -06:00
Jeremiah C Leary f0c474c695 Updates for issue #280:
The rule process_012 would add the *is* keyword to the end of the process sensitivity list without removing an *is* keyword if it existed on a different line.

  1)  Updated documentation
  2)  Updated tests
  3)  Updated process classifier
  4)  Added isProcessIs line attribute
  5)  Updated rule process_012 to remove the *is* keyword if is exists on a seperate line.
2019-12-05 09:52:59 -06:00
Jeremiah C Leary 791021b799 Updates for issue #284:
The indent level of the begin keyword was incorrect in cases of processes without sensitivity lists.

  1)  Changed indent level to match that of the process keyword in all cases.
  2)  Updated tests
2019-10-20 07:20:49 -05:00
Jeremiah C Leary 23bc434ff6 Updates for issue #257:
Process labels not on the same line as the process must be moved to the same line as the process keyword.

  1)  Updated documentation
  2)  Added tests
  3)  Added rule process_032
2019-10-13 11:16:29 -05:00
Jeremiah C Leary fa3cc96da0 Updates for issue #232:
Added test case for mixed single and multiple signal names.
2019-06-08 15:26:52 -05:00
Jeremiah C Leary 8acd9604c0 Updates for issue #232:
Updated process_030 to specifically look for a single signal every line of a sensitivity list.

  1)  Updated tests
  2)  Updated rule
2019-06-08 15:22:15 -05:00
Jeremiah C Leary 6f7ae69e55 Updates for issue #220:
Invalid classification of procedure "begin" keyword as a process "begin" keyword.

  1)  Updated tests to include testcase
  2)  Updated code to handle testcase
2019-03-22 17:26:42 -05:00
Jeremiah C Leary 1948b70444 Updates for Codacy issues:
Removing trialing whitespaces.
2019-03-10 12:19:16 -05:00
Jeremiah C Leary 183b9f5c18 Updates for issue #193
The class vhdlFile now takes a list instead of a file name.
This removes the responsibility of reading the file from the vhdlFile class.
Which allows for better integration into other tools.
2019-02-24 12:49:25 -06:00
Jeremiah C Leary 5f5eee4571 Updates for issue #203
Made process detection ignore commented out code.

  1)  Updated test
  2)  Updated classifier
2019-02-11 18:13:50 -06:00
Jeremiah C Leary 9a68c25937 Fixing issues identified by Codacy. 2018-12-18 08:43:16 -06:00
Jeremiah C Leary bf9f5779cd Updates for issue #192
1)  Reduced scope of constant_009 to the architecture declaritive region
  2)  Refactored constant fix tests to be independent using the setUp method
  3)  Updated documentation
2018-12-17 21:03:35 -06:00
Jeremiah C Leary 59d097ed73 Updates for issue #192
Worked out all the issues with the new rule.

  1)  Updated documentation
  2)  Updated check and fix classes to support new rule
  3)  Updated tests
  4)  Updated rule to work correctly
2018-12-17 19:31:43 -06:00
Jeremiah C Leary 97450b89b6 Updates for issue #192
1)  Moved whitespace_012 to process_031
  2)  Added checks for alignment of colons
  3)  Added documentation
2018-12-16 10:49:27 -06:00
Jeremiah C Leary 43e0259612 Updates for issue #154
Added process_030 to detect a single signal on a single line of a process sensitivity list, minus the last line.

  1)  Added test
  2)  Added rule
  3)  Added documentation
2018-12-06 17:44:32 -06:00
Jeremiah C Leary c031527690 Updates for issue #186
1)  Made end architecture more restrictive.
  2)  Updated tests
2018-12-03 19:26:57 -06:00
Jeremiah C Leary 2ac0e8ee8e Updates for issue #184
Added support for processs without sensitivity lists.
2018-12-01 10:09:17 -06:00
Jeremiah C Leary a479b22c3d Updates for issue #182
1)  Updated test to detect generics and ports starting with "process"
  2)  Restricted classifier to look for the whole word "process"
2018-11-29 19:49:10 -06:00
Jeremiah C Leary fb27c4434a Updates for issue #166:
1)  Fixed classification of "begin" keyword in comments
  2)  Updated tests
  3)  Split vhdlFile process tests into their own file
2018-09-13 22:28:22 -05:00
Jeremiah C Leary 742a808003 Updates for issue #152
1)  Made process_029 less greedy when searching for rising_edge and falling_edge
2018-07-30 21:50:21 -05:00
Jeremiah C Leary b055aa9b1f Removing unused imports to address Codacy issues. 2017-12-24 07:32:32 -06:00
Jeremiah C Leary 14767e773d Updates for issue #96
1)  Added process_029
  2)  Added tests
  3)  Updated code examples
  4)  Added documentation
2017-12-10 18:33:17 -06:00
Jeremiah C Leary 1dcbfd87b6 Updates for issue #101
1)  Removed checking of closing parenthesis from process_020.
  2)  Added process_028 to check for alignment of closing parenthesis.
  3)  Added tests
  4)  Added documentation
2017-12-07 06:34:17 -06:00
Jeremiah C Leary 33b64c00b4 Updates after running against sample code:
1)  Fixed line attributes for ports, process and signals
2017-11-24 09:03:23 -06:00
Jeremiah C Leary 5987bd929d Updates for code coverage. 2017-11-23 10:59:54 -06:00
Jeremiah C Leary 12a585171c Updates for issue #52:
1)  Fixed easy code coverage issues.
2017-11-22 06:45:06 -06:00
Jeremiah C Leary 0d20c90350 Updates for issue #38:
1)  Added fixes for process rules.
2017-11-20 21:27:13 -06:00