* Issue#1059: Performance improvements:
* Added lower value to token and removed .lower() in other files
* Simplified find_next_token
* Attempt at new algorithm for closest pair.
NOTE: attempt has been commented out.
* WIP: Improved token pairs process:
NOTE: It does not appear to complete all the matches.
* Revert "WIP: Improved token pairs process:"
This reverts commit f41254087e84caa42b02058fd9fbb6cfcce673fc.
* Revert "Attempt at new algorithm for closest pair."
This reverts commit 4a972793883b9aa54a6e7ccd15e1cc26b8296fec.
* Updates for black.
* Issue#1081: Adding configuration option for constant_400
* Adding options to concurrent_400 and sequential_400.
* Refactored base rules to improve readability.
* Merging base rules:
align_tokens_in_region_between_tokens_unless_between_tokens merged into align_tokens_in_region_between_tokens
* Adding ignore_single_line_aggregates to rule constant_400
* Removing commented out code.
* Refactoring align_tokens_in_region_between_token_when_between_tokens_unless_between_tokens.
* Removing unused alignment options due to refactor.
* Updates for issue #852
Adding support the attributes in subtype indications.
1) Updated classifier subtype_indication to call type_mark
2) Updated get_sequence_of_tokens_matching
* Removing comments.
* Updates for issue #559:
Adding documentation for configuring indent rules.
* Adding documentation:
1) Updated whitespace_002
2) Added whitespace_014
3) Added configuring tabs vs spaces
* Adding example documentation.
Fixing table.
* Updated documentation:
1) Removed whitespace_014
2) Updated whitespace_002 to only work on middle tabs
3) Removed configuring_tabs_vs_spaces document
4) Removed tabs as an option for indenting
* Updating token indent rules.
* Adding smart_tabs test for rule assert_statement_001
* Updating rule assert_400 to allow smart tabs.
* Refactoring assert_400 to improve readability.
* Refactoring to reduce complexity.
* Updates for rule case_011 and assert_400:
1) Replaced align_consecutive_lines_after_line_starting_with_token_and_stopping_with_token with assert_400
2) Updated rule assert_400 to inherit align rule
3) Changed rule case_011 to use align rule
* Removing rule case_021.
The function of the rule is now covered by comment_010.
* Deprecating rule case_generate_alternative_300.
* Refactoring analyze to _analyze.
* Splitting configuration of rule assert_400 into its own page.
* Updating multiline_alignment_between_tokens to handle smart tabs.
* Deprecating rules if_032 and if_033. They are covered by comment_010.
* Updated report_statement_400 to use align_consecutive_lines_after_line_starting_with_token_and_stopping_with_token.
* Updating rule process_028 to handle smart-tabs
1) Updated tests
2) Updated base rule align_left_token_with_right_token_if_right_token_starts_a_line
* Updating rule library_009 to handle smart-tabs
1) Updated tests
2) Updated base rule align_consecutive_lines_starting_with_a_comment_above_line_starting_with_token
* Minor formatting updates.
* Adding methods to support multiline alignment base class.
* Refactored rule constant_012 to split indent and alignment whitespace.
* Adding smart-tab support to rule constant_012.
* Removing old classify code.
* Removing debug print statement.
* Updating documentation for assert and report_statement rules.
* Updating rule concurrent_009 to support smart-tabs.
1) Added tests
2) Updated rule to support smart-tabs
* Updating documentation to match current implementation.
* Taking a different approach for multiline_alignment_between_tokens.
1) Reverted smart_tabs changes
2) Updated base rule to method employed on concurrent_009
3) Commented out smart_tab tests
* Updated missing meta data to Toi in rule constant_014
Fixed error in align_left_no_align_paren_no analyzer.
* Adding smart-tab support to base rule multiline_alignment_between_tokens.
* Updating alignment rules to support smart tabs.
1) Updated base rules
a) vsg/rules/align_tokens_in_region_between_tokens.py
b) vsg/rules/align_tokens_in_region_between_tokens_skipping_lines_starting_with_tokens.py
c) vsg/rules/align_tokens_in_region_between_tokens_unless_between_tokens.py
2) Updated rule concurrent_008
3) Added tests
* Fixing issue with rule port_map_009 misfiring if the following token sequence occured: comma, whitespace, carraige return.
* Updating solution for indent rules to give required tabs and spaces.
Fixing several bugs in indent implementation:
1) checking for smart-tabs instead of smart_tabs
* Updates for Codacy issues.
* Additional Codacy updates.
* Fixing style issues identified by CodeClimate.
* Additional style fixes identified by CodeClimate.
* Refactoring alignment rules:
1) Created utils file specifically for alignment rules
2) Refactored rules to move identical code into utils file
* Moving update_column_width into alignment_utils file.
* Moving functions into alignment_utils:
1) get_first_line_info
2) starts_with_paren
* Using functions in alignment_utils.
* Collapsing branches to improve readability.
* Refactoring to improve readability.
* Updates for issue #539
Adding multiline structural rule for rule signal_016.
1) Added test cases
2) Update rule signal_016
3) Updated documentation
* Adding test for arrays.
* Adding functions to combine slices into a single object
* Adding array_first_paren_new_line option.
* Removing unused code.
* Adding tests for the following parameter options:
1) array_first_paren_new_line (yes/no)
2) first_paren_new_line (yes/no)
* Adding documentation for configuring multiline constraint rules.
* Minor grammar updates.
* Updating per feedback:
1) Made symbols in table with a transparent background
2) Minor grammar updates
3) Fixed indenting in code examples
* Adding correct red penta star png file.
* Upated third example to correctly show behavior.
* Updated figure with correct indenting.
Fixed indenting in example 2.
* Adjusting indent on example 3 and example 4.
* Initial rewrite to classify constraints.
* Converting variable_declaration to call subtype_indication.classify.
* Changing constant_declaration to use subtype_indication.classify
* Changing unbounded_array_definition to use subtype_indication.classify
* Changing subtype_declaration to use subtype_indication.classify
* Changed interface_variable_declaration to call subtype_indication.classify
* Changing the following to use subtype_indication.classify:
interface_constant_declaration
interface_file_declaration
interface_signal_declaration
interface_unkown_declaration
* Changing the following to use subtype_indication.classify:
constrained_array_definition
* Changing the following to use subtype_indication.classify
element_subtype_definition
* Changing the following to use subtype_indication.classify:
alias_declaration
* removing commented out line.
* Changing the following to use subtype_indication.classify:
file_declaration
* Changing the following to use subtype_indication.classify
access_type_definition
* Removing subtype_indication.classify_until
* Initial commit of rule signal_017
* Implemented record_constraint_open_paren = add_new_line
* Minor refactoring.
* Extracted the following functions:
_check_add_new_line
_token_at_beginning_of_line
* Adding the following options to rule signal_017
* record_constraint_open_paren :: remove_new_line
* Adding the following options:
record_constraint_close_paren :: add_new_line
record_constraint_close_paren :: remove_new_line
* Adding the following options:
record_constraint_comma :: remove_new_line
* Adding the following option:
record_constraint_element :: add_new_line
record_constraint_element :: remove_new_line
* Adding the following option:
* array_constraint :: all_in_one_line
* Fixing issue with array_constraint::all_in_one_line not detecting multiline array_constraints.
* Adding the following options:
array_constraint :: one_line_per_dimension
* Adding rule signal_400 to handle indenting of multiline signal constraints.
* Fixing issues for Codacy.
* Refactoring to reduce complexity and improve readability.
* Adding links to new rules.
* Refactoring to improve readability.
* Refactoring to improve readability.
* Fixing style issues.
* Updating for style issues.
* Updating formatting issues.
* Removing unused file.
* Removing commented out debug statements.
* Minor formatting updates.
* Adding metadata attribute and methods.
* Refactoring _check_array_contraint_one_line_per_dimension function to improve readability.
* Refactoring _check_array_constraint_all_in_one_line function to improve readability.
* Refactoring _create_violation to just take oToi as a parameter.
* Adding exception logic.
* Refactoring to improve readability.
* Refactored analyze_exception_one to improve readability.
* Refactoring the following functions:
* _check_array_constraint_all_in_one_line
* _check_array_constraint_one_line_per_dimension
* Refactoring the following functions:
* add_index_constraint_open_parenthesis
* add_index_constraint_close_parenthesis
* add_record_constraint_open_parenthesis
* add_record_constraint_close_parenthesis
* Refactoring to improve readability.
* Minor formatting updates.
* Adjusting signal_400 to remove extra level of indent.
* Updates for rule signal_400:
1) Modified base rule multiline_alignment_between_tokens to support signal_400
2) Added tests for the four variants of options.
* Fixing style issues.
* Simplifying _check_new_line_after_comma function.
* Deprecating rule signal_016.
* Removing unused base rule multiline_declaration_structure.
* Style and minor refactorings.
* Moving filtering of toi's from _analyze to _get_tokens_of_interest.
* Extracted update_open_paren_counter from _classify_assignment
* Extracted update_close_paren_counter form _classify_assignment
* Refactoring _fix_violation to reduce complexity
* Refactored _create_violation:
1) Placed violation information into oToi object
* Refactoring to reduce complexity.
* Adding rule constant_017
* Adding rule variable_017
* Updating links to rules.
* Adding rule variable_400.
* Minor cleanup of documentation.
* Adding default values for options.
* Minor updates for formatting:
* Updates for issue #730
Adding rules to handle case for use_clause selected names.
1) Added new tokens to use_clause
2) selected names now parsed with new tokens
3) Added rules:
a) use_clause_500
b) use_clause_501
c) use_clause_502
d) use_clause_503
4) Added tests
Resolves#730
* Refactoring to reduce duplication.
Removing trailing whitespace.
* Changing exceptions to case_exceptions.
1) case::name rules allow case_exceptions by default
2) Updated instantiated_unit to split entity_name with a library name
3) Rule instantiation_028 simplified
4) Removed unused test file
* Refactoring to reduce complexity.
* Refactoring to improve readability.
* Fixed isue with procedure_506 crashing VSG due to missing variable.
* Fixing missing call to lowercase list.
* Adding the following rules:
context_ref_500
context_ref_501
Deprecated the following rules:
context_ref_004
* Placing common code into a single file.
* Removing trailing whitespace.
* Refactoring to reduce the number of parameters.
* Updates for issue #750
Fixed code tags to allow for comments within the tag.
1) Updated tests
2) Updated documentation
3) Updated code tag logic to ignore anything after the : within the code tag
* Additional code tag updates
Added parsing of exponents.
* Minor formatting fixes.
* Refactored split_natural_numbers to improve readability.
* Refactoring code tag logic to improve readability.
* Minor formatting updates.
* Removing trailing whitespace.
* Refactoring to improve readability.
* Refactoring to reduce line length.
* Fixing indent.
* Adding rule exponent_500.
* Updates for issue #542:
Rule comment_010 was firing after block_comment rules were ran:
1) Updated indent logic to take block comments into consideration
2) Added attributes to comment class to indicate if it is a block comment
3) Updated tests
4) Simplified extractor
5) Added method to token_map
* Refactoring functions to reduce duplication and complexity.
* Removing trailing whitespace.
* Removing excess blank lines.
* Refactoring to remove identical code.
* Refactoring to reduce complexity.
* Refactoring to reduction complexity.
* Refactoring to improve readability.
* Reverting to previous utils.py due to inadvertant commit.
* Refactoring block_comment_002 to reduce complexity and improve readability.
* Refactored block_comment_002 to reduce complexity.
* Refactoring block_comment_002 to reduce complexity.
* Refactoring block_comment_002 to improve readability.
* Refactoring to improve readability.
* Moving _analyze from block_comment_002 and block_comment_003 into base block_rule.
* Minor formatting updates.
* Updated base rule to ignore leading and trailing vsg code tags.
* Forcing tags of vsg_on to be applied on the next token.
* Refactoring methods to make them more readable.
* Update for issue #575:
Fixing alignment rules as they were introducing syntax errors:
align_tokens_in_region_between_tokens
align_tokens_in_region_between_tokens_skiping_lines_starting_with_tokens
* Refactoring to improve readability.
* Addressing issues from Codacy and Codeclimate
* Refactoring number_of_tokens_in_token_list to improve readability.
* Refactoring utils functions to improve readability.
* Removing unused variable.
* An exit statement with a <= was being classified as a signal assignment.
* Fixed issue with improper classification of character literals.
* Extracting class from tokens.py
* Refactoring tokens.py to improve readability.
* Fixing issue when attempting to detect trailing whitespace.
* Updating tests to reflect changes in tokens.py
* Refactoring combine_characters_into_words to improve readability.
* Refactoring combine_string_literals to improve readability.
* Refactoring find_indexes_of_double_quote_pairs to improve readability.
* Refactoring combine_character_literals to improve readability.
* Refactoring to improve readability.
* Removing unused functions.
* Adding additional tests for tokenizer.
* Moving rule variable_assignment_004 to phase 5 and subphase 2 to ensure it runs correctly.
* Updating documentation for variable_assignment_004 change in phase.
* Rule constant_012 was operating on constant which were not arrays.
* Removing unused function.
* Removing unused function.
* Moving rule generic_001 to entity_200 to properly handle generic_clause in a package declaration.
* Refactoring extract routines to improve readability.
* Refactoring base rule to improve readability.
* Fixing Minor formatting issues.
* Removing unused function.
* Removing unused functions.
* Improving code coverage.
* Improving code coverage:
1) Removed unused functions
2) Removed unreachable code
* Refactoring constant_012 to improve readability.
* Refactoring analyze to _analyze:
1) Updated _get_tokens_of_interest to add more info into the token object
* Refactoring to improve readability.
* Refactoring generate_paren_dicts function to improve readability.
* Refactoring check_indents to improve readability.
* Refactoring to improve readability.
* Updates for rule constant_012:
1) Arguments align_left False and align_paren True working
* Refactored analyze_align_left_true_align_paren_false function in rule constant_012
* Refactored _analyze_align_paren_true_align_left_true function for rule constant_012.
* Removed unused functions and methods for rule constant_012.
* Updated rule constant_012 to use the indent step
* Refactoring to functions into methods.
* Removing unused file.
* Refactoring rule constant_012 to improve readability.
* Additional refactoring to improve readability.
* Refactoring check_left_aligned_line function to use less parameters.
* Removing unused variables.
* Attempting to get JSON extract test to pass on CI server.
* Removing unused functions.
* Updates for rule comment_100:
Rule was error out if a comment was only 3 characters and the third was not a letter or number.
1) Updated test
2) Added check for length of comment
* Updates for parsing procedure_calls_statements:
Procedure call with <= was being classified as a simple waveform.
1) Updated test to expose issue
2) Updated classification code
* Refactoring to reduce cyclomatic complexity.
* Refactoring to reduce cyclomatic complexity.
* Minor formatting updates.
* Adding parsing of physical_type_definitions:
1) Added tokens
a) physical_type_definition
b) primary_unit_declaration
c) secondary_unit_declaration
2) Added classifiers
a) physical_type_definition
b) primary_unit_declaration
c) secondary_unit_declaration
3) Added test
a) full_type_declaration
* Minor formatting fix.
* Fixed bug with concurrent_simple_signal_assignment.
A <= in a generic map was causing the generic map to be classified as a concurrent_simple_signal_assignment.
1) Updated test
2) Updated concurrent_simple_signal_assignment classifier
* Refactoring to reduce cyclomatic complexity.
* Adding classification of configuration_specification:
1) Added tests
2) Added classifiers for configuration_specification.
* Minor formatting updates.
* Fixing issue with previous_line rule if there were no lines above.
* Assert_statement was being classified before exiting block_statement.
* A backslash in a string literal was not be classified as a string literal.
Adding rule whitespace_001 to detect and fix trailing whitespace.
1) Updated documentation
2) Added tests for whitespace_001
3) Removed trailing whitespace for test files which are not testing whitespace_001
4) Added rule whitespace_001
Adding ability for the user to adjust the indenting algorithm.
1) Added documentation
2) Refactored indent algorithm
a) Changed algorithm to use a YAML configuration file
3) Added indent dictionary to -oc output
4) Updated tests to use new YAML configuration file