351 lines
13 KiB
Python
351 lines
13 KiB
Python
|
|
from vsg import rule
|
|
import re
|
|
|
|
|
|
class if_rule(rule.rule):
|
|
|
|
def __init__(self):
|
|
rule.rule.__init__(self)
|
|
self.name = 'if'
|
|
|
|
|
|
class rule_001(if_rule):
|
|
'''If rule 001 checks for the proper indentation at the beginning of the line.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '001'
|
|
self.solution = 'Ensure proper indentation.'
|
|
self.phase = 4
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isIfKeyword or oLine.isElseIfKeyword or oLine.isEndIfKeyword or oLine.isElseKeyword:
|
|
self._check_indent(oLine, iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations:
|
|
self._fix_indent(oFile.lines[iLineNumber])
|
|
|
|
|
|
class rule_002(if_rule):
|
|
'''If rule 002 checks the if boolean expression is enclosed in ()'s.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '002'
|
|
self.solution = 'Enclose boolean expression in ()\'s.'
|
|
self.phase = 1
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isIfKeyword:
|
|
if not re.match('^\s*if\s*\(', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
if oLine.isElseIfKeyword:
|
|
if re.match('^\s*elsif\s+\w', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations:
|
|
oLine = oFile.lines[iLineNumber]
|
|
if oLine.isIfKeyword:
|
|
oLine.update_line(oLine.line.replace('if', 'if ('))
|
|
if oLine.isElseIfKeyword:
|
|
oLine.update_line(oLine.line.replace('elsif', 'elsif ('))
|
|
iThenLineIndex = iLineNumber
|
|
while not oLine.isThenKeyword:
|
|
iThenLineIndex += 1
|
|
oLine = oFile.lines[iThenLineIndex]
|
|
oLine.update_line(oLine.line.replace('then', ') then'))
|
|
|
|
|
|
class rule_003(if_rule):
|
|
'''If rule 003 checks there is a single space between the if keyword and the (.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '003'
|
|
self.solution = 'Ensure only a single space exists between the "if" keyword and the (.'
|
|
self.phase = 2
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isIfKeyword:
|
|
if re.match('^\s*if\s*\(', oLine.lineLower):
|
|
if not re.match('^\s*if\s\(', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations:
|
|
self._enforce_one_space_after_word(oFile.lines[iLineNumber], 'if')
|
|
|
|
|
|
class rule_004(if_rule):
|
|
'''If rule 004 checks there is a single space between the ) and "then" keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '004'
|
|
self.solution = 'Ensure only a single space exists between the ) and "then" keyword.'
|
|
self.phase = 2
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isThenKeyword:
|
|
if re.match('^\s*.*\)\s*then', oLine.lineLower):
|
|
if not re.match('^\s*.*\)\sthen', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations:
|
|
self._enforce_one_space_before_word(oFile.lines[iLineNumber], 'then')
|
|
|
|
|
|
class rule_005(if_rule):
|
|
'''If rule 005 checks there is a single space between the "elsif" keyword and the (.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '005'
|
|
self.solution = 'Ensure only a single space exists between the "elsif" keyword and the (.'
|
|
self.phase = 2
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isElseIfKeyword:
|
|
if re.match('^\s*elsif\s*\(', oLine.lineLower):
|
|
if not re.match('^\s*elsif\s\(', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations:
|
|
self._enforce_one_space_after_word(oFile.lines[iLineNumber], 'elsif')
|
|
|
|
|
|
class rule_006(if_rule):
|
|
'''If rule 006 checks for an empty line after the then keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '006'
|
|
self.solution = 'Remove blank line(s) after the "then" keyword.'
|
|
self.phase = 3
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isThenKeyword and not oFile.lines[iLineNumber + 2].isCaseKeyword and not oLine.isEndIfKeyword:
|
|
self._is_no_blank_line_after(oFile, iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
self._remove_blank_lines_below(oFile, iLineNumber)
|
|
|
|
|
|
class rule_007(if_rule):
|
|
'''If rule 007 checks for an empty line before the "elsif" keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '007'
|
|
self.solution = 'Remove blank line(s) before the "elsif" keyword.'
|
|
self.phase = 3
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isElseIfKeyword:
|
|
self._is_no_blank_line_before(oFile, iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
self._remove_blank_lines_above(oFile, iLineNumber)
|
|
|
|
|
|
class rule_008(if_rule):
|
|
'''If rule 008 checks for an empty line before the "end if" keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '008'
|
|
self.solution = 'Remove blank line(s) before the "end if" keyword.'
|
|
self.phase = 3
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isEndIfKeyword and not oFile.lines[iLineNumber - 2].isEndCaseKeyword and not oLine.isIfKeyword:
|
|
self._is_no_blank_line_before(oFile, iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
self._remove_blank_lines_above(oFile, iLineNumber)
|
|
|
|
|
|
class rule_009(if_rule):
|
|
'''If rule 009 checks the alignment of multiline boolean expressions.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '009'
|
|
self.solution = 'Align with space after ( in first line of boolean expression.'
|
|
self.phase = 5
|
|
|
|
def analyze(self, oFile):
|
|
fCheckAlignment = False
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isIfKeyword and oLine.isThenKeyword:
|
|
continue
|
|
if oLine.isElseIfKeyword and oLine.isThenKeyword:
|
|
continue
|
|
if oLine.isIfKeyword:
|
|
if re.match('^\s+if\s\(', oLine.lineLower):
|
|
iAlignmentColumn = oLine.lineLower.find('(')
|
|
fCheckAlignment = True
|
|
continue # pragma: no cover
|
|
if oLine.isElseIfKeyword:
|
|
if re.match('^\s+elsif\s\(', oLine.lineLower):
|
|
iAlignmentColumn = oLine.lineLower.find('(')
|
|
fCheckAlignment = True
|
|
continue # pragma: no cover
|
|
if oLine.insideIf and fCheckAlignment:
|
|
self._check_multiline_alignment(iAlignmentColumn + 1, oLine, iLineNumber)
|
|
if oLine.isThenKeyword:
|
|
fCheckAlignment = False
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.dFix['violations']:
|
|
self._fix_multiline_alignment(oFile, iLineNumber)
|
|
|
|
|
|
class rule_010(if_rule):
|
|
'''If rule 010 checks for an empty line before the "else" keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '010'
|
|
self.solution = 'Remove blank line(s) before the "else" keyword.'
|
|
self.phase = 3
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isElseKeyword and not oFile.lines[iLineNumber - 2].isEndCaseKeyword and not oLine.isIfKeyword:
|
|
self._is_no_blank_line_before(oFile, iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
self._remove_blank_lines_above(oFile, iLineNumber)
|
|
|
|
|
|
class rule_011(if_rule):
|
|
'''If rule 011 checks for an empty line after the "else" keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '011'
|
|
self.solution = 'Remove blank line(s) after the "else" keyword.'
|
|
self.phase = 3
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isElseKeyword and not oFile.lines[iLineNumber + 2].isCaseKeyword and not oLine.isEndIfKeyword:
|
|
self._is_no_blank_line_after(oFile, iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
self._remove_blank_lines_below(oFile, iLineNumber)
|
|
|
|
|
|
class rule_012(if_rule):
|
|
'''If rule 012 checks for code after the "then" keyword.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '012'
|
|
self.solution = 'Move code after "then" or "else" keyword to the next line.'
|
|
self.phase = 1
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isThenKeyword:
|
|
if re.match('^.*\sthen\s+\w', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
elif oLine.isElseKeyword:
|
|
if re.match('^.*\selse\s+\w', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
oFile.lines.insert(iLineNumber + 1,oFile.lines[iLineNumber])
|
|
oLine = oFile.lines[iLineNumber]
|
|
if oLine.isThenKeyword:
|
|
iIndex = oLine.line.find(' then') + len(' then') + 1
|
|
oLine.update_line(oLine.line[:iIndex])
|
|
oLine.isThenKeyword = False
|
|
oLine = oFile.lines[iLineNumber + 1]
|
|
oLine.update_line(oLine.line[iIndex:])
|
|
oLine.isIfKeyword = False
|
|
elif oLine.isElseKeyword:
|
|
iIndex = oLine.line.find(' else') + len(' else') + 1
|
|
oLine.update_line(oLine.line[:iIndex])
|
|
oLine.isElseKeyword = False
|
|
oLine = oFile.lines[iLineNumber + 1]
|
|
oLine.update_line(oLine.line[iIndex:])
|
|
oLine.isIfKeyword = False
|
|
|
|
|
|
class rule_013(if_rule):
|
|
'''If rule 013 checks the "else" keyword is on it's own line.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '013'
|
|
self.solution = 'Move "else" keyword to it\'s own line.'
|
|
self.phase = 1
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isElseKeyword:
|
|
if not re.match('^\s*else', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
oFile.lines.insert(iLineNumber + 1,oFile.lines[iLineNumber])
|
|
oLine = oFile.lines[iLineNumber]
|
|
iIndex = oLine.line.find(' else')
|
|
oLine.update_line(oLine.line[:iIndex])
|
|
oLine.isElseKeyword = False
|
|
oLine = oFile.lines[iLineNumber + 1]
|
|
oLine.update_line(oLine.line[iIndex:])
|
|
oLine.isIfKeyword = False
|
|
|
|
|
|
class rule_014(if_rule):
|
|
'''If rule 014 checks the "end if" keyword is on it's own line.'''
|
|
|
|
def __init__(self):
|
|
if_rule.__init__(self)
|
|
self.identifier = '014'
|
|
self.solution = 'Move "end if" keyword to it\'s own line.'
|
|
self.phase = 1
|
|
|
|
def analyze(self, oFile):
|
|
for iLineNumber, oLine in enumerate(oFile.lines):
|
|
if oLine.isEndIfKeyword:
|
|
if not re.match('^\s*end\s+if', oLine.lineLower):
|
|
self.add_violation(iLineNumber)
|
|
|
|
def _fix_violations(self, oFile):
|
|
for iLineNumber in self.violations[::-1]:
|
|
oFile.lines.insert(iLineNumber + 1,oFile.lines[iLineNumber])
|
|
oLine = oFile.lines[iLineNumber]
|
|
iIndex = oLine.line.find(' end')
|
|
oLine.update_line(oLine.line[:iIndex])
|
|
oLine.isEndIfKeyword = False
|
|
oLine = oFile.lines[iLineNumber + 1]
|
|
oLine.update_line(oLine.line[iIndex:])
|
|
oLine.isIfKeyword = False
|
|
oLine.isElseKeyword = False
|
|
oLine.isElseIfKeyword = False
|
|
oLine.isThenKeyword = False
|