vhdl-style-guide/tests/vsg/test_main.py

626 lines
22 KiB
Python

# -*- coding: utf-8 -*-
import contextlib
import filecmp
import os
import pathlib
import shutil
import subprocess
import sys
import unittest
from io import StringIO
from tempfile import TemporaryDirectory
from unittest import mock
import yaml
from tests import utils
from vsg import __main__, version
class command_line_args:
"""This is used as an input into the version command."""
def __init__(self, version=False):
self.version = version
self.style = "indent_only"
self.configuration = []
self.debug = False
self.fix_only = False
self.stdin = False
self.force_fix = False
self.fix = False
class testMain(unittest.TestCase):
def setUp(self):
self._tmpdir = TemporaryDirectory()
def tearDown(self):
self._tmpdir.cleanup()
@mock.patch("sys.stdout")
def test_multiple_configuration_w_multiple_filelists(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4."))
lExpected.append(mock.call("\n"))
lExpected.append(mock.call("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_1.json", "tests/vsg/config_2.json"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_single_configuration_w_filelist(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_1.json"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_2.json"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_single_configuration_w_rule_disable(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_3.json"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_multiple_configuration_w_rule_disable(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_3.json", "tests/vsg/config_4.json"])
sys.argv.extend(["-f", "tests/vsg/entity1.vhd"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_invalid_configuration(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: Invalid configuration file: tests/vsg/config_error.json"))
lExpected.append(mock.call("\n"))
lExpected.append(
mock.call("while parsing a flow node\nexpected the node content, but found ','\n in \"tests/vsg/config_error.json\", line 2, column 16"),
)
lExpected.append(mock.call("\n"))
junit_file = os.path.join(self._tmpdir.name, "config_error.actual.xml")
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_error.json"])
sys.argv.extend(["-f", "tests/vsg/entity1.vhd"])
sys.argv.extend(["--junit", junit_file])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
# Read in the expected JUnit XML file for comparison
lExpected = []
utils.read_file(os.path.join(os.path.dirname(__file__), "config_error.expected.xml"), lExpected)
# Read in the actual JUnit XML file for comparison
lActual = []
utils.read_file(junit_file, lActual)
# Compare the two files, but skip the line with the timestamp (as it will never match)
for iLineNumber, sLine in enumerate(lExpected):
if iLineNumber != 1:
self.assertEqual(sLine, lActual[iLineNumber])
@mock.patch("sys.stderr")
def test_junit_with_file_that_fails_to_parse(self, mock_stderr):
lStdErr = []
lStdErr.append("Error while processing tests/vsg/junit/parse_error.vhd: ")
lStdErr.append("Error: Unexpected token detected while parsing architecture_body @ Line 4, Column 1 in file tests/vsg/junit/parse_error.vhd")
lStdErr.append(" Expecting : begin")
lStdErr.append(" Found : end")
junit_file = os.path.join(self._tmpdir.name, "config_error.actual.xml")
lExpected = []
lExpected.append(mock.call("\n".join(lStdErr) + "\n"))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["-f", "tests/vsg/junit/parse_error.vhd"])
sys.argv.extend(["--junit", junit_file])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stderr.write.assert_has_calls(lExpected)
# Read in the expected JUnit XML file for comparison
lExpected = []
utils.read_file(os.path.join(os.path.dirname(__file__), "junit", "parse_error.expected.xml"), lExpected)
# Read in the actual JUnit XML file for comparison
lActual = []
utils.read_file(junit_file, lActual)
# Compare the two files, but skip the line with the timestamp (as it will never match)
for iLineNumber, sLine in enumerate(lExpected):
if iLineNumber != 1:
self.assertEqual(sLine, lActual[iLineNumber])
self.assertTrue('failures="1"' in lActual[1])
@mock.patch("sys.stdout")
def test_junit_with_file_with_no_errors(self, mock_stderr):
junit_file = os.path.join(self._tmpdir.name, "config_error.actual.xml")
sys.argv = ["vsg"]
sys.argv.extend(["-f", "tests/vsg/junit/no_error.vhd"])
sys.argv.extend(["--junit", junit_file])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
# Read in the expected JUnit XML file for comparison
lExpected = []
utils.read_file(os.path.join(os.path.dirname(__file__), "junit", "no_error.expected.xml"), lExpected)
# Read in the actual JUnit XML file for comparison
lActual = []
utils.read_file(junit_file, lActual)
# Compare the two files, but skip the line with the timestamp (as it will never match)
for iLineNumber, sLine in enumerate(lExpected):
if iLineNumber != 1:
self.assertEqual(sLine, lActual[iLineNumber])
self.assertTrue('failures="0"' in lActual[1])
@mock.patch("sys.stdout")
def test_local_rules(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity_architecture.vhd(1)localized_001 -- Split entity and architecture into separate files."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--style", "jcl"])
sys.argv.extend(["-f", "tests/vsg/entity_architecture.vhd"])
sys.argv.extend(["-lr", "tests/vsg/local_rules"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_invalid_local_rule_directory(self, mock_stdout):
lExpected = []
lExpected.append(
mock.call(
"ERROR: encountered FileNotFoundError, No such file or directory tests/vsg/invalid_local_rule_directory when trying to open local rules file.",
),
)
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["-f", "tests/vsg/entity_architecture.vhd"])
sys.argv.extend(["-lr", "tests/vsg/invalid_local_rule_directory"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
def test_globbing_filenames_in_configuration(self):
lExpected = []
lExpected.append("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3.")
lExpected.append("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4.")
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_glob.json"])
sys.argv.extend(["-p 1"])
temp_stdout = StringIO()
with contextlib.redirect_stdout(temp_stdout):
try:
__main__.main()
except SystemExit:
pass
lActual = temp_stdout.getvalue().strip().split("\n")
if lActual[0] == lExpected[1]:
lExpected = [lExpected[1], lExpected[0]]
self.assertEqual(lExpected, lActual)
@mock.patch("sys.stdout")
def test_single_yaml_configuration_w_filelist(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_1.yaml"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_2.json"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_multiple_yaml_configuration_w_multiple_filelists(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4."))
lExpected.append(mock.call("\n"))
lExpected.append(mock.call("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_1.yaml", "tests/vsg/config_2.yaml"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_single_yaml_configuration_w_rule_disable(self, mock_stdout):
lExpected = []
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_3.yaml"])
sys.argv.extend(["-f", "tests/vsg/entity1.vhd"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_multiple_yaml_configuration_w_rule_disable(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4."))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_3.yaml", "tests/vsg/config_4.yaml"])
sys.argv.extend(["-f", "tests/vsg/entity1.vhd"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_reverse_yaml_multiple_configuration_w_rule_disable(self, mock_stdout):
lExpected = []
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_4.yaml", "tests/vsg/config_3.yaml"])
sys.argv.extend(["-f", "tests/vsg/entity1.vhd"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
def test_globbing_filenames_in_yaml_configuration(self):
lExpected = []
lExpected.append("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3.")
lExpected.append("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4.")
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_glob.yaml"])
sys.argv.extend(["-p 1"])
temp_stdout = StringIO()
with contextlib.redirect_stdout(temp_stdout):
try:
__main__.main()
except SystemExit:
pass
lActual = temp_stdout.getvalue().strip().split("\n")
if lActual[0] == lExpected[1]:
lExpected = [lExpected[1], lExpected[0]]
self.assertEqual(lExpected, lActual)
@mock.patch("sys.stdout")
def test_oc_command_line_argument(self, mock_stdout):
lExpected = []
config_file = os.path.join(self._tmpdir.name, "deleteme.json")
sys.argv = ["vsg"]
sys.argv.extend(["-oc", config_file])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_rule_disabled_under_file(self, mock_stdout):
lExpected = []
sys.argv = ["vsg"]
sys.argv.extend(["-c", "tests/vsg/config_rule_disabled_under_file.yaml"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
def test_json_parameter(self):
self.maxDiff = None
lExpected = []
lExpected.append("ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after *out* to 3.")
lExpected.append("ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after *in* to 4.")
config_file = os.path.join(self._tmpdir.name, "deleteme.json")
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["--configuration", "tests/vsg/config_glob.yaml"])
sys.argv.extend(["--json", config_file])
sys.argv.extend(["-p 1"])
temp_stdout = StringIO()
with contextlib.redirect_stdout(temp_stdout):
try:
__main__.main()
except SystemExit:
pass
self.assertTrue(config_file)
sFileName = os.path.join(os.path.dirname(__file__), "json-expected.json")
with open(sFileName) as yaml_file:
dExpected = yaml.full_load(yaml_file)
with open(config_file) as yaml_file:
dActual = yaml.full_load(yaml_file)
lExpected = dExpected["files"]
lActual = dActual["files"]
self.assertEqual(len(lExpected), len(lActual))
iCompares = 0
for dExpectedEntry in lExpected:
for dActualEntry in lActual:
if dExpectedEntry["file_path"] == dActualEntry["file_path"]:
self.assertEqual(dExpectedEntry, dActualEntry)
iCompares += 1
self.assertEqual(iCompares, len(lExpected))
@mock.patch("sys.stdout")
def test_backup_file(self, mock_stdout):
test_file = os.path.join(self._tmpdir.name, "entity1.vhd")
backup_file = test_file + ".bak"
shutil.copyfile("tests/vsg/entity1.vhd", test_file)
lExpected = []
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["-f", test_file])
sys.argv.extend(["--fix"])
sys.argv.extend(["--backup"])
sys.argv.extend(["-p 1"])
try:
__main__.main()
except SystemExit:
pass
self.assertTrue(os.path.isfile(backup_file))
self.assertTrue(filecmp.cmp("tests/vsg/entity1.vhd", backup_file))
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_backup_file_without_fix(self, mock_stdout):
test_file = os.path.join(self._tmpdir.name, "entity1.vhd")
backup_file = test_file + ".bak"
shutil.copyfile("tests/vsg/entity1.vhd", test_file)
lExpected = []
lExpected.append(mock.call("ERROR: --backup argument requires --fix argument"))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["-f", test_file])
sys.argv.extend(["--backup"])
sys.argv.extend(["-p 1"])
with self.assertRaises(SystemExit) as cm:
__main__.main()
mock_stdout.write.assert_has_calls(lExpected)
self.assertEqual(cm.exception.code, 1)
self.assertFalse(os.path.isfile(backup_file))
@mock.patch("sys.stdout")
def test_ap_with_fix(self, mock_stdout):
lExpected = []
lExpected.append(mock.call("ERROR: -ap argument is invalid with the --fix argument"))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg"]
sys.argv.extend(["--output_format", "syntastic"])
sys.argv.extend(["-f", "tests/vsg/entity1.vhd"])
sys.argv.extend(["-ap"])
sys.argv.extend(["--fix"])
sys.argv.extend(["-p 1"])
with self.assertRaises(SystemExit) as cm:
__main__.main()
mock_stdout.write.assert_has_calls(lExpected)
self.assertEqual(cm.exception.code, 1)
@mock.patch("sys.stdout")
def test_syntastic_output_with_multiple_errors(self, mock_stdout):
sOutput = ""
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(2)architecture_004 -- Change "ARCHITECTURE" to "architecture"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(2)architecture_013 -- Change "RTL" to "rtl"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(2)architecture_014 -- Change "FIFO" to "fifo"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(2)architecture_019 -- Change "OF" to "of"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(2)architecture_020 -- Change "IS" to "is"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(4)architecture_021 -- Change "BEGIN" to "begin"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(6)architecture_009 -- Change "END" to "end"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(6)architecture_011 -- Change "RTL" to "rtl"\n'
sOutput += 'ERROR: tests/vsg/syntastic/syntastic.vhd(6)architecture_028 -- Change "ARCHITECTURE" to "architecture"'
lExpected = []
lExpected.append(mock.call(sOutput))
lExpected.append(mock.call("\n"))
sys.argv = ["vsg", "-f", "tests/vsg/syntastic/syntastic.vhd", "-of", "syntastic", "-p", "1"]
try:
__main__.main()
except SystemExit:
pass
mock_stdout.write.assert_has_calls(lExpected)
@mock.patch("sys.stdout")
def test_deprecated_options(self, mock_stdout):
sys.argv = ["vsg", "-f", "tests/vsg/deprecated_option/example.vhd", "-of", "syntastic", "-p", "1"]
sys.argv.extend(["-c", "tests/vsg/deprecated_option/rule.yaml"])
sys.argv.extend(["tests/vsg/deprecated_option/global.yaml"])
sys.argv.extend(["tests/vsg/deprecated_option/group.yaml"])
sys.argv.extend(["tests/vsg/deprecated_option/file_list.yaml"])
sys.argv.extend(["tests/vsg/deprecated_option/file_rules.yaml"])
sys.argv.extend(["tests/vsg/deprecated_option/all.yaml"])
try:
__main__.main()
except SystemExit:
pass
sOutput = ""
sOutput += "ERROR: configuration file tests/vsg/deprecated_option/rule.yaml: option indentSize has been deprecated. Change to indent_size."
sOutput += "\n"
sOutput += "ERROR: configuration file tests/vsg/deprecated_option/rule.yaml: option indentStyle has been deprecated. Change to indent_style."
sOutput += "\n"
lExpected = []
lExpected.append(mock.call(sOutput))
mock_stdout.write.assert_has_calls(lExpected)