From 433054dd7e8640ffbd471614f1816bf14280b9be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20CAMPO?= Date: Tue, 18 Feb 2025 22:01:13 +0100 Subject: [PATCH] correcting generate_select_query additional blank space and its associated tests --- weaponry/src/database.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/weaponry/src/database.rs b/weaponry/src/database.rs index bca6039..54e608f 100644 --- a/weaponry/src/database.rs +++ b/weaponry/src/database.rs @@ -30,14 +30,14 @@ fn generate_select_query( filter: Option<&str>, ) -> String { format!( - "SELECT {} FROM {} {};", + "SELECT {} FROM {}{};", T::attributes_map() .into_iter() .map(|(k, _v)| k) .collect::>() - .join(", "), + .join(","), table_name, - filter.unwrap_or("") + filter.map_or_else(String::default, |j| " ".to_string() + j) ) } @@ -70,7 +70,7 @@ mod test { id: usize, name: String, } - + /// setting up test db and table, also adding arbitrary data inside fn mock_set_up(db_filename: &str) -> EquipementDatabase { let equip_db = EquipementDatabase::new(db_filename).unwrap(); equip_db.conn.execute("CREATE TABLE IF NOT EXISTS TestStruct (id INTEGER UNIQUE, name TEXT, PRIMARY KEY('id' AUTOINCREMENT));",()).unwrap(); @@ -93,11 +93,11 @@ mod test { fn test_generate_query() { assert_eq!( generate_select_query::("TestStruct", None), - "SELECT id, name FROM TestStruct ;" + "SELECT id,name FROM TestStruct;" ); assert_eq!( generate_select_query::("TestStruct", Some("WHERE id=id")), - "SELECT id, name FROM TestStruct WHERE id=id;" + "SELECT id,name FROM TestStruct WHERE id=id;" ); }