From f534944b1049b3308a21726cba983796fc0f8cfd Mon Sep 17 00:00:00 2001 From: Dandaedre Date: Fri, 20 Nov 2026 06:44:42 +0100 Subject: [PATCH] Make previous-slide preview opt-in for default layouts --- Cargo.lock | 2 +- Cargo.toml | 2 +- crates/pdf-presenter/src/settings.rs | 2 +- crates/pdf-presenter/tests/settings.rs | 3 +++ docs/changelog.md | 5 +++++ docs/interfaces/settings.md | 3 ++- docs/user-guide.md | 2 ++ 7 files changed, 15 insertions(+), 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 9dcb7c7..2d7ba32 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2212,7 +2212,7 @@ dependencies = [ [[package]] name = "pdf-presenter" -version = "0.1.34" +version = "0.1.35" dependencies = [ "bytemuck", "chrono", diff --git a/Cargo.toml b/Cargo.toml index 7d8496c..5fda3d8 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -4,7 +4,7 @@ default-members = ["crates/pdf-presenter"] resolver = "3" [workspace.package] -version = "0.1.34" +version = "0.1.35" edition = "2024" license = "MIT" repository = "https://proxy.dandaedre.com/gitea/idle-org/pdf-presenter" diff --git a/crates/pdf-presenter/src/settings.rs b/crates/pdf-presenter/src/settings.rs index 6d47f8b..7ed11d5 100644 --- a/crates/pdf-presenter/src/settings.rs +++ b/crates/pdf-presenter/src/settings.rs @@ -49,7 +49,7 @@ impl Default for Layout { fn default() -> Self { Self { previous: Widget { - show: true, + show: false, size: 60., }, current: Widget { diff --git a/crates/pdf-presenter/tests/settings.rs b/crates/pdf-presenter/tests/settings.rs index d16efb3..d9954ba 100644 --- a/crates/pdf-presenter/tests/settings.rs +++ b/crates/pdf-presenter/tests/settings.rs @@ -11,6 +11,7 @@ fn settings_roundtrip_preserves_project_overrides_and_hidden_bars() { settings.theme = pdf_presenter::theme::Theme::CorporateLight; settings.language = pdf_presenter::localization::Language::Fr; let mut project = Layout::default(); + project.previous.show = true; // Explicit opt-in survives saving and loading. project.current.show = false; project.header = false; project.footer = false; @@ -63,6 +64,8 @@ fn settings_reject_invalid_versions_ranges_and_duplicate_roles() { assert!(settings::read(&p).is_err()); std::fs::write(&p, "version=1").unwrap(); assert!(settings::read(&p).unwrap().layout.header); + assert!(!settings::read(&p).unwrap().layout.previous.show); + assert!(!Layout::default().previous.show); assert_eq!(settings::read(&p).unwrap().buffer_mib, 1024); assert!(settings::read(&p).unwrap().auto_show); } diff --git a/docs/changelog.md b/docs/changelog.md index 7eac895..943d2c0 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -2,6 +2,11 @@ ## Unreleased +### 0.1.35 + +- Hide the previous-slide preview by default; enable it in Layout. Preserve explicit + visibility choices in saved layouts and verify default/opt-in persistence. + ### 0.1.34 - Restrict keepawake to its supported Linux, Windows and macOS targets so the diff --git a/docs/interfaces/settings.md b/docs/interfaces/settings.md index 5d6d80b..f8ba8b1 100644 --- a/docs/interfaces/settings.md +++ b/docs/interfaces/settings.md @@ -35,7 +35,8 @@ flushed temporary file. Unknown fields are ignored and not preserved on round tr - `layout`: `previous`, `current`, `next`, `notes`, `elapsed`, `clock`, each with boolean `show` and finite floating `size`; plus boolean `header`/`footer`. Previous/next sizes are relative weights 30–160, current 60–200; notes size - is percentage 12–65; elapsed/clock sizes are logical pixels 16–72. Defaults are in `settings.rs`. + is percentage 12–65; elapsed/clock sizes are logical pixels 16–72. Defaults are in `settings.rs`. Since 0.1.35, the previous-slide widget defaults + to hidden; an explicitly saved `previous.show` value is preserved. - `layout.elapsed_position` and `layout.clock_position`: `header` (default), `above_slides`, or `below_notes`, added in 0.1.24. Independent presenter-only placement presets; unknown values are rejected. Body timer rows reserve space diff --git a/docs/user-guide.md b/docs/user-guide.md index d313026..95670af 100644 --- a/docs/user-guide.md +++ b/docs/user-guide.md @@ -87,6 +87,8 @@ do not navigate. Output windows accept B/Escape for emergency blanking. Layout independently enables and sizes previous/current/next slides, notes, elapsed time and the local HH:MM clock. Hidden widgets release their space. Notes wrap and automatically shrink to fit; extremely long notes can become too small to read. +The previous-slide preview is off by default; enable **Previous slide** in Layout +when you want it. Saved layouts keep their chosen visibility. Menu → Reset timer starts elapsed time again. Bundled UI fonts cover their supplied character sets; broad CJK text coverage remains a packaging acceptance item.