From daa897573a04d777be3dd68f46eb4689f30cf8d7 Mon Sep 17 00:00:00 2001 From: Dandaedre Date: Mon, 16 Nov 2026 15:32:48 +0100 Subject: [PATCH] Translate crop action labels in layer menus --- crates/canvas-pilot/src/gui.rs | 37 +++++++++++++++++++++++++++++++++- docs/canvas-pilot/changelog.md | 3 +++ 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/crates/canvas-pilot/src/gui.rs b/crates/canvas-pilot/src/gui.rs index 20ffcea..27fedbb 100644 --- a/crates/canvas-pilot/src/gui.rs +++ b/crates/canvas-pilot/src/gui.rs @@ -2197,7 +2197,7 @@ impl Editor { "crop.adjust" }; if ui - .add_enabled(!self.automatic_layer_fit(i), egui::Button::new(crop_label)) + .add_enabled(!self.automatic_layer_fit(i), egui::Button::new(tr(ui.ctx(), crop_label))) .on_disabled_hover_text("Centered and Cropped fit automatically; use Crop properties for numeric crop edges.") .on_hover_text( tr(ui.ctx(), "ui.change-crop-zoom-and-offset-inside-the-layer-keep-its-visible-box-fixed"), @@ -8128,6 +8128,41 @@ mod tests { assert_eq!(app.fields, original); } + #[test] + fn crop_menu_renders_translations_in_both_editing_states() { + for language in localization::Language::ALL { + let ctx = egui::Context::default(); + language.apply(&ctx); + for editing in [false, true] { + let mut app = Editor { + edit_content: editing, + ..Default::default() + }; + assert!(app.layout.selected().is_some()); + let output = ctx.run(egui::RawInput::default(), |ctx| { + egui::CentralPanel::default().show(ctx, |ui| app.layer_context_menu(ui)); + }); + let expected = tr(&ctx, if editing { "crop.done" } else { "crop.adjust" }); + let labels: Vec<_> = output + .shapes + .iter() + .filter_map(|shape| match &shape.shape { + egui::Shape::Text(text) => Some(text.galley.text()), + _ => None, + }) + .collect(); + assert!( + labels.contains(&expected.as_str()), + "{language:?}: missing {expected}" + ); + assert!( + !labels.iter().any(|label| label.starts_with("crop.")), + "raw key in {language:?} menu" + ); + } + } + } + #[test] fn viewport_and_list_context_actions_target_the_clicked_layer() { for list in [false, true] { diff --git a/docs/canvas-pilot/changelog.md b/docs/canvas-pilot/changelog.md index 8c87f0d..f533b31 100644 --- a/docs/canvas-pilot/changelog.md +++ b/docs/canvas-pilot/changelog.md @@ -4,6 +4,9 @@ ## Unreleased +- Fixed raw `crop.adjust` / `crop.done` translation keys in the layer context menu. + A rendered-menu regression test covers both editing states in every language. + - Added Japanese, Simplified Chinese, Spanish, Ancient Greek and Esperanto software translations with immediate language switching. All are unverified machine translations; device terminology and document/clipboard content stay unchanged.