Compare commits

...

2 Commits

Author SHA1 Message Date
Dandaedre 0bf23d70b5 test: stabilize coverage gate in CI
Rust CI Cargo tests, coverage, and badge generation passed.
Gitea/rust_realease/pipeline/head This commit looks good Details
2026-11-21 14:47:56 +01:00
Dandaedre 79bf210a15 test: raise coverage above CI threshold
Rust CI Cargo tests, coverage, or badge generation failed.
Gitea/rust_realease/pipeline/head There was a failure building this commit Details
2026-11-21 14:39:40 +01:00
2 changed files with 322 additions and 0 deletions

View File

@ -906,6 +906,31 @@ mod tests {
}
}
#[test]
fn preparation_options_are_rejected_before_project_acquisition() {
let error = run(Cli::parse_from([
"rust_realease",
"missing-project",
"--commit-preparation",
]))
.unwrap_err();
assert!(error
.to_string()
.contains("Preparation options require --prepare-repo"));
let error = run(Cli::parse_from([
"rust_realease",
"missing-project",
"--prepare-repo",
"--stop-after",
"metadata",
]))
.unwrap_err();
assert!(error
.to_string()
.contains("--prepare-repo is a separate mode"));
}
#[test]
fn release_message_inputs_and_recompile_flag_parse() {
let args = Cli::try_parse_from([
@ -1043,4 +1068,95 @@ mod tests {
Some(Path::new("secrets/gitea-token"))
);
}
fn endpoint(name: &str, token_env: &str) -> ReleaseEndpoint {
ReleaseEndpoint {
name: name.into(),
provider: crate::config::ReleaseProvider::Gitea,
repository: "https://example.com/team/demo".into(),
token_env: token_env.into(),
}
}
#[test]
fn endpoint_tokens_are_selected_and_validated() {
let primary = endpoint("primary", "RUST_RELEASE_TEST_PRIMARY_TOKEN");
let mirror = endpoint("mirror", "RUST_RELEASE_TEST_MIRROR_TOKEN");
let plain = TokenFile::Plain("plain-secret".into());
assert_eq!(
token_for_endpoint(Some(&plain), &primary, 1).unwrap(),
"plain-secret"
);
assert!(token_for_endpoint(Some(&plain), &primary, 2).is_err());
let named = TokenFile::Named(BTreeMap::from([
("primary".into(), "one".into()),
("mirror".into(), "two".into()),
]));
assert_eq!(token_for_endpoint(Some(&named), &mirror, 2).unwrap(), "two");
assert!(token_for_endpoint(Some(&TokenFile::Named(BTreeMap::new())), &primary, 1).is_err());
assert!(validate_token_keys(Some(&named), &[primary.clone(), mirror]).is_ok());
assert!(validate_token_keys(Some(&named), &[primary]).is_err());
assert!(validate_token_keys(None, &[]).is_ok());
}
#[test]
fn token_file_rejects_non_files_and_invalid_json_values() {
let temp = tempfile::tempdir().unwrap();
assert!(read_token_file(temp.path()).is_err());
let path = temp.path().join("tokens.json");
for invalid in [
"{",
"{}",
r#"{"primary":""}"#,
"{\"primary\":\"line\\nbreak\"}",
] {
fs::write(&path, invalid).unwrap();
assert!(read_token_file(&path).is_err(), "accepted {invalid:?}");
}
}
#[test]
fn macos_workaround_covers_zip_archive_binary_and_shell_escaping() {
let bundle = Artifact {
target: "x86_64-apple-darwin".into(),
path: "dist/demo portable.zip".into(),
contents: ArtifactContents::Bundle {
root: "demo's bundle".into(),
format: Format::Zip,
entries: vec![],
},
sha256: "0".repeat(64),
};
let archive = Artifact {
target: "aarch64-apple-darwin".into(),
path: "dist/demo.tgz".into(),
contents: ArtifactContents::Archive {
root: "demo".into(),
binaries: vec!["demo".into()],
},
sha256: "1".repeat(64),
};
let binary = Artifact {
target: "aarch64-apple-darwin".into(),
path: "dist/demo-bin".into(),
contents: ArtifactContents::Binary,
sha256: "2".repeat(64),
};
let message = release_message_with_macos_workaround(None, &[bundle])
.unwrap()
.unwrap();
assert!(message.contains("ditto -x -k"));
assert!(message.contains("demo'\"'\"'s bundle"));
let message = release_message_with_macos_workaround(None, &[archive])
.unwrap()
.unwrap();
assert!(message.contains("tar -xzf"));
let message = release_message_with_macos_workaround(None, &[binary])
.unwrap()
.unwrap();
assert!(message.contains("xattr -d com.apple.quarantine \"$executable\""));
}
}

View File

@ -424,4 +424,210 @@ mod tests {
assert!(Github::with_token(repository, "token").is_err());
}
}
#[test]
fn updates_existing_annotated_release_and_replaces_colliding_asset() {
let (host, handle) = server(vec![
Reply {
method: "GET",
path: "/repos/team/demo/git/ref/tags/v1.0.0",
status: 200,
body: r#"{"object":{"type":"tag","sha":"tag-object"}}"#,
},
Reply {
method: "GET",
path: "/repos/team/demo/git/tags/tag-object",
status: 200,
body: r#"{"object":{"sha":"abc"}}"#,
},
Reply {
method: "GET",
path: "/repos/team/demo/releases/tags/v1.0.0",
status: 200,
body: r#"{"id":7,"draft":false}"#,
},
Reply {
method: "PATCH",
path: "/repos/team/demo/releases/7",
status: 200,
body: "",
},
Reply {
method: "GET",
path: "/repos/team/demo",
status: 200,
body: r#"{"private":true}"#,
},
Reply {
method: "GET",
path: "/repos/team/demo/releases/7/assets?per_page=100",
status: 200,
body: r#"[{"id":11,"name":"asset.bin"}]"#,
},
Reply {
method: "DELETE",
path: "/repos/team/demo/releases/assets/11",
status: 204,
body: "",
},
Reply {
method: "POST",
path: "/repos/team/demo/releases/7/assets?name=asset.bin",
status: 201,
body: "{}",
},
]);
let api = Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
let release = api
.ensure_release("v1.0.0", "abc", false, false, Some("new notes"), true)
.unwrap();
assert_eq!(release.id, 7);
assert!(api.repository_private().unwrap());
let _ = api.download_client();
let temp = tempfile::tempdir().unwrap();
let asset = temp.path().join("asset.bin");
std::fs::write(&asset, b"replacement").unwrap();
api.upload(release.id, &[asset.as_path()], true).unwrap();
let bodies = handle.join().unwrap();
assert!(String::from_utf8_lossy(&bodies[3]).contains("new notes"));
assert_eq!(bodies[7], b"replacement");
}
#[test]
fn reports_missing_mismatched_and_malformed_github_responses() {
let cases = [
(404, "{}", "missing"),
(
200,
r#"{"object":{"type":"commit","sha":"other"}}"#,
"differs",
),
(200, "not json", "invalid JSON"),
(500, "{}", "HTTP 500"),
];
for (status, body, expected) in cases {
let (host, handle) = server(vec![Reply {
method: "GET",
path: "/repos/team/demo/git/ref/tags/v1.0.0",
status,
body,
}]);
let api =
Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
let error = api
.ensure_release("v1.0.0", "abc", false, false, None, false)
.unwrap_err();
assert!(error.to_string().contains(expected), "{error}");
handle.join().unwrap();
}
}
#[test]
fn reports_malformed_release_repository_and_asset_responses() {
let (host, handle) = server(vec![Reply {
method: "GET",
path: "/repos/team/demo/git/ref/tags/v1.0.0",
status: 200,
body: r#"{"object":{"type":"tag"}}"#,
}]);
let api = Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
assert!(api
.ensure_release("v1.0.0", "abc", false, false, None, false)
.unwrap_err()
.to_string()
.contains("object SHA"));
handle.join().unwrap();
let (host, handle) = server(vec![
Reply {
method: "GET",
path: "/repos/team/demo/git/ref/tags/v1.0.0",
status: 200,
body: r#"{"object":{"type":"commit","sha":"abc"}}"#,
},
Reply {
method: "GET",
path: "/repos/team/demo/releases/tags/v1.0.0",
status: 200,
body: "{}",
},
]);
let api = Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
assert!(api
.ensure_release("v1.0.0", "abc", false, false, None, false)
.unwrap_err()
.to_string()
.contains("missing id"));
handle.join().unwrap();
for (path, operation, expected) in [
("/repos/team/demo", "repository", "visibility"),
(
"/repos/team/demo/releases/7/assets?per_page=100",
"assets",
"invalid",
),
] {
let (host, handle) = server(vec![Reply {
method: "GET",
path,
status: 200,
body: "{}",
}]);
let api =
Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
let error = if operation == "repository" {
api.repository_private().unwrap_err()
} else {
api.asset_urls(7).unwrap_err()
};
assert!(error.to_string().contains(expected), "{error}");
handle.join().unwrap();
}
}
#[test]
fn refuses_asset_collision_and_reports_upload_http_failure() {
let temp = tempfile::tempdir().unwrap();
let asset = temp.path().join("asset.bin");
std::fs::write(&asset, b"asset").unwrap();
let (host, handle) = server(vec![Reply {
method: "GET",
path: "/repos/team/demo/releases/7/assets?per_page=100",
status: 200,
body: r#"[{"id":11,"name":"asset.bin"}]"#,
}]);
let api = Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
assert!(api.upload(7, &[asset.as_path()], false).is_err());
handle.join().unwrap();
let (host, handle) = server(vec![
Reply {
method: "GET",
path: "/repos/team/demo/releases/7/assets?per_page=100",
status: 200,
body: "[]",
},
Reply {
method: "POST",
path: "/repos/team/demo/releases/7/assets?name=asset.bin",
status: 500,
body: "{}",
},
]);
let api = Github::with_origins("https://github.com/team/demo", "test-token", &host, &host)
.unwrap();
let error = api.upload(7, &[asset.as_path()], false).unwrap_err();
assert!(error.to_string().contains("HTTP 500"), "{error}");
handle.join().unwrap();
}
}