ravenous_roll20/TASKS.md

132 lines
8.4 KiB
Markdown

# Ravenous sheet worklist
This list tracks the next development steps from [AGENTS.md](AGENTS.md).
Mark an item complete only after its stated check passes. Keep a note of the
Roll20 test date and any failures; local worker tests do not reproduce Roll20's
parser, browser, or chat.
## Done locally
- [x] Generate the sheet from the pinned `ravenous_typst` data and run the
Python build tests (`uv run python -m unittest discover -s tests -v`).
- [x] Add local worker tests (`node tests/test_worker.mjs`) for derived values,
resistance and protection summaries, technique import, skill outcomes,
attack follow-up calculations, and damage mitigation.
- [x] Verify generated artifacts with `./scripts/build.sh --check`.
- [x] Add a persistent in-sheet theme selector generated from every palette in
the book data, including matching chat-card themes.
- [x] Add a minimal GM-only Roll20 Mod proof of concept that creates one
character from a JSON `name`; test valid and invalid commands locally.
- [x] Add origin powers from the pinned book data stage by stage in an editable
Powers tab, while preserving custom rows and preventing duplicate imports.
- [x] Add a GM-only character JSON export/import Mod script and a monster
database converter. Verify round trips, repeating rows, invalid input, and
all master-visible monsters locally.
- [x] Allow players to export controlled characters and restore them in place
without changing character IDs, token links, ownership, or GM-only notes.
- [x] Define the versioned craft JSON interface and add a permission-aware Mod
importer for weapons, protections, consumables, and temporary effects.
Validate all destinations, handout input, and invalid payloads locally.
- [x] Add structured start/end-turn reminders to temporary effects, including
turn countdowns, expiration notices, and copying reminder configuration from
consumables. Keep mechanical changes manual.
- [x] Generate, validate, and archive a deterministic randomized character JSON
fixture covering all repeating sections in Jenkins. Import it through the Mod
simulator when Node is available on the build agent.
- [x] Generate and archive deterministic forge and alchemy craft fixtures that
exercise all four destinations supported by the Roll20 craft importer.
- [x] Move all three Jenkins publication targets from `/mnt/books` to
`/mnt/assets/ravenous_roll20`, keep branch-specific siblings allow-listed,
and create missing product directories. **2026-10-04:** static pipeline
assertions and deterministic build checks pass locally; publication on the
Jenkins agent remains to be observed on the next mapped-branch build.
- [x] Add Python line coverage and mutable CI badges following the shared badge
contract. **2026-10-04:** the local coverage command measured 91.8% line
coverage against an 85% floor; renderer and temporary-root publication tests
pass. After the `main` build, all three public URLs returned HTTP 200, parsed
as XML and reported version 0.1.0, passing tests and 92% rounded coverage.
- [x] Reduce the README to onboarding, first use, navigation, development and
license/status information; move Roll20 use, Mod workflows and CI details to
focused documentation. **2026-10-04:** local links and anchors resolve, all
retained public links return HTTP 200, and the documented quick-start and
validation commands pass locally.
## Next: Roll20 smoke test
- [ ] Install `roll20_mod/ravenous_craft_import.js`, import one entry of each
supported type from inline JSON and from a private handout, then reopen the
destination sheet and confirm every field persists.
- [x] Install `roll20_mod/ravenous_import_name.js` as a New Script in a test
game, run `!ravenous-import-name {"name":"Ariane"}` as GM, and confirm a
single new character appears in the journal. **2026-09-17:** user reports
that the test worked in Roll20.
- [x] Install `roll20_mod/ravenous_character_io.js` in a test game. Export an
edited sheet, save its JSON outside Roll20, import it from a GM handout, and
compare notes, abilities, attributes, and repeating rows. Import one converted
monster and check each mapped row and any worker recalculations. **2026-09-17:**
user reports this workflow completed successfully in Roll20;
`local_exports/character.json` is the local saved export and is excluded from Git.
- [x] Load `build/ravenous.html`, `build/ravenous.css`, and
`build/translation.json` into a Custom Sheet Sandbox with Legacy Sanitization
disabled. Record the date, browser, and any console or worker errors.
**2026-09-17 attempt:** user supplied a Firefox console log (browser inferred
from Firefox-specific messages). It shows `Starting up WEB WORKER`, CSP
warnings for inline scripts/event handlers, Sentry CDN CORS/integrity errors,
and `Uncaught SyntaxError: missing ] after element list` in `vtt.bundle`.
**Follow-up, 2026-09-17:** user confirms all Legacy Sanitization is disabled.
A new Firefox log reports `SyntaxError: "" string literal contains an unescaped
line break` from `sheetsandbox.bundle.js` after sheet worker startup. The
generated worker parses and passes local Node tests. Generated data was split
into shorter source lines (the longest is now under 3.5 KB instead of 128 KB)
as a compatibility attempt. **Final retest, 2026-09-17:** user reports the
sheet now works with Legacy Sanitization disabled. The supplied console log
shows sheet worker startup and no worker syntax error; only VTT startup,
a CSP frame notice, and a layout warning remain.
- [x] Select an alternate theme and inspect the sheet and chat cards for
legibility and contrast in Roll20. **2026-09-17:**
user reports that the themes work perfectly.
- [ ] Create an attacker and defender, plus a token representing the defender.
Open both sheets; switch every tab; add, edit, delete, and reorder a repeating
row. Reopen each sheet and confirm values persist. **2026-09-17:** user reports
values appear to persist; repeating row reorder still needs explicit confirmation.
- [x] Change base and temporary characteristics, stage, a skill rank, and a
custom skill. Confirm the displayed totals update and that derived stats use
the permanent characteristic as intended. **2026-09-17:** user reports
calculations done in Roll20.
- [x] Add one technique, attempt to add it again, and activate its chat card.
Check that text is readable and free of raw Typst markup. **2026-09-17:**
user reports techniques work in Roll20.
- [x] Select an origin, add one stage of powers, try adding it again, then add
another stage and a custom power. Change origin and reopen
the sheet. Confirm existing rows persist and selection alone adds no rows.
**2026-09-17:** user reports powers work in Roll20.
- [ ] Roll a skill at the threshold boundary and on a natural 1. Check chat
outcome and margin. Try public and secret rolls. **2026-09-17:** user reports
rolls generally work but CF was marked one above the die maximum. The worker
now marks the maximum face as critical failure; retest in Roll20.
- [ ] Roll an attack, use its **Défendre** chat button with the defender token
targeted when prompted, then use **Dégâts** and **Subir**. Test zero successes, more successes
than RMax, multiple checked resistances, one active protection, depleted
integrity, and a fixed location. Confirm DMG and AB against hand calculations.
**2026-09-17:** user reports repeated missing-selected-token warnings when
clicking without a token. The worker now requests one named target; retest.
- [ ] Repeat an attack follow-up after closing and reopening the sheet. Record
whether the attack context survives; the current worker stores it in memory.
**2026-09-17:** user believes it works; verify damage values after reopening.
## After smoke test
- [ ] Fix each observed Roll20 defect with a focused reproduction and a local
test where the behavior can be simulated. Recheck it in the sandbox.
- [ ] Compare derived statistics, defense thresholds, damage, and AB formulas
with the pinned rulebook. Record the rule reference and any intentional
deviation before changing mechanics.
- [x] Decide whether HP should update automatically. **2026-09-17:** user
decided to keep HP updates manual for now.
- [x] Decide whether armor integrity, technique costs, and temporary effects
should update automatically. **2026-09-17:** user wants all these updates
manual for now.
- [ ] Add local worker tests to Jenkins only after confirming Node is installed
on its build agent, or provision a pinned Node runtime there.